Add config flag to override all initial Soroban limits #3900
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jayz22
reviewed
Aug 29, 2023
| e.txMaxReadBytes *= 10; | ||
| e.txMaxWriteLedgerEntries *= 10; | ||
| e.txMaxWriteBytes *= 10; | ||
| } |
There was a problem hiding this comment.
I think instead of multiplying individual setting by a scaling factor, we should define all the test configs in a new structure TestInitialSorobanNetworkConfig. This way is more clear and easy to maintain.
jayz22
reviewed
Aug 29, 2023
6 tasks
|
Are we going with TestOverrideSorobanNetworkConfig struct approach from #3901 instead? |
Yeah |
|
Closed in favor of #3901 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolves #3897
Checklist
clang-formatv8.0.0 (viamake formator the Visual Studio extension)