Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new option to sorobaninfo command to output full settings in the same format as the dumpproposedsettings command #4088

Merged
merged 2 commits into from
Dec 18, 2023
Merged

Add new option to sorobaninfo command to output full settings in the same format as the dumpproposedsettings command #4088

merged 2 commits into from
Dec 18, 2023

Conversation

sisuresh
Copy link
Contributor

Description

Resolves #3822

Checklist

  • Reviewed the contributing document
  • Rebased on top of master (no merge commits)
  • Ran clang-format v8.0.0 (via make format or the Visual Studio extension)
  • Compiles
  • Ran all tests
  • If change impacts performance, include supporting evidence per the performance document

@sisuresh sisuresh requested a review from anupsdf December 12, 2023 22:54
@SirTyson SirTyson self-requested a review December 14, 2023 23:12
SirTyson
SirTyson approved these changes Dec 14, 2023
View reviewed changes
Copy link
Contributor

@SirTyson SirTyson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, a few nit pics.

@sisuresh sisuresh changed the title Add new option to sorobaninfo command to output fill settings in the same format as the dumpproposedsettings command Add new option to sorobaninfo command to output full settings in the same format as the dumpproposedsettings command Dec 15, 2023
@sisuresh sisuresh requested a review from dmkozh December 15, 2023 17:06
@dmkozh
Copy link
Contributor

dmkozh commented Dec 18, 2023

r+ 1d1654b

@latobarita latobarita merged commit f8e348d into stellar:master Dec 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SirTyson SirTyson SirTyson approved these changes

@anupsdf anupsdf Awaiting requested review from anupsdf

@dmkozh dmkozh Awaiting requested review from dmkozh

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add a few helper command lines to help schedule and review network settings upgrades
4 participants
@sisuresh @dmkozh @latobarita @SirTyson