-
Notifications
You must be signed in to change notification settings - Fork 988
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix soroban test upgrades #4654
Merged
SirTyson
merged 3 commits into
stellar:master
from
SirTyson:fix-soroban-test-upgrades-2
Mar 27, 2025
Merged
Fix soroban test upgrades #4654
SirTyson
merged 3 commits into
stellar:master
from
SirTyson:fix-soroban-test-upgrades-2
Mar 27, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fdbeacc
to
5c0152f
Compare
sisuresh
previously approved these changes
Feb 26, 2025
dmkozh
previously approved these changes
Mar 26, 2025
marta-lokhova
previously approved these changes
Mar 26, 2025
eb78578
5c0152f
to
eb78578
Compare
dmkozh
previously approved these changes
Mar 26, 2025
eb78578
to
3498e29
Compare
marta-lokhova
previously approved these changes
Mar 26, 2025
02e132b
to
78ceab5
Compare
78ceab5
to
3bdb21f
Compare
marta-lokhova
approved these changes
Mar 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolves #4605
This test makes the following changes:
TestAccount
to be managed by AppTestAccount
objects for the one actual account.TestAccount
caches the next sequence number, so this approach cause issues since oneTestAccount
root object would be out of sync with the others. This change makes it such that there is only oneTestAccount
object for the root.modifySorobanNetworkConfig
goes through full upgrade processledgerClose
flow. Now, we actually go through the correct upgrade contract upload -> invoke -> arm -> externalize upgrade ledger flow.modifySorobanNetworkConfig
now closes 4 ledgers. The root account also pays for these TXs, so balances have changed slightly as well.ledgerMaxDependentTxClusters
in upgrade related tests.Checklist
clang-format
v8.0.0 (viamake format
or the Visual Studio extension)