Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Homepage - Wayfinding #1005

Merged
merged 44 commits into from
Dec 20, 2024
Merged

Homepage - Wayfinding #1005

merged 44 commits into from
Dec 20, 2024

Conversation

briwylde08
Copy link
Contributor

No description provided.

@stellar-jenkins
Copy link

Preview is available here:
http://developers-pr1005.previews.kube001.services.stellar-ops.com

@briwylde08 briwylde08 marked this pull request as draft September 25, 2024 22:52
@stellar-jenkins
Copy link

Preview is available here:
http://developers-pr1005.previews.kube001.services.stellar-ops.com

@stellar-jenkins
Copy link

Preview is available here:
http://developers-pr1005.previews.kube001.services.stellar-ops.com

@stellar-jenkins
Copy link

Preview is available here:
http://developers-pr1005.previews.kube001.services.stellar-ops.com

@stellar-jenkins
Copy link

Preview is available here:
http://developers-pr1005.previews.kube001.services.stellar-ops.com

@briwylde08 briwylde08 marked this pull request as ready for review October 4, 2024 20:22
@stellar-jenkins
Copy link

Preview is available here:
http://developers-pr1005.previews.kube001.services.stellar-ops.com

chowbao
chowbao reviewed Oct 28, 2024
View reviewed changes
src/pages/index.mdx Outdated Show resolved Hide resolved
chowbao
chowbao reviewed Oct 28, 2024
View reviewed changes
src/pages/index.mdx Outdated Show resolved Hide resolved
chowbao
chowbao reviewed Oct 28, 2024
View reviewed changes
src/pages/index.mdx Outdated Show resolved Hide resolved
chowbao
chowbao reviewed Oct 28, 2024
View reviewed changes
src/pages/index.mdx Outdated Show resolved Hide resolved
chowbao
chowbao reviewed Oct 28, 2024
View reviewed changes
src/pages/index.mdx Outdated Show resolved Hide resolved
chowbao
chowbao reviewed Oct 28, 2024
View reviewed changes
src/pages/index.mdx Outdated Show resolved Hide resolved
@stellar-jenkins
Copy link

Preview is available here:
http://developers-pr1005.previews.kube001.services.stellar-ops.com

@stellar-jenkins
Copy link

Preview is available here:
http://developers-pr1005.previews.kube001.services.stellar-ops.com

@stellar-jenkins
Copy link

Preview is available here:
http://developers-pr1005.previews.kube001.services.stellar-ops.com

@stellar-jenkins
Copy link

Preview is available here:
http://developers-pr1005.previews.kube001.services.stellar-ops.com

@stellar-jenkins
Copy link

Preview is available here:
http://developers-pr1005.previews.kube001.services.stellar-ops.com

@stellar-jenkins
Copy link

Preview is available here:
http://developers-pr1005.previews.kube001.services.stellar-ops.com

@sdfcharles
Copy link

sdfcharles commented Dec 20, 2024 •
edited
Loading

cc @janewang @briwylde08 @ElliotFriend

Design notes:

CleanShot 2024-12-20 at 10 53 17@2x

  • can we expand the boxes to the full edge to match?
  • can we semi-bold the titles?
  • "Learn More" needs a space

CleanShot 2024-12-20 at 10 53 46@2x

  • can we expand the boxes to the full edge to match?
  • can we semi-bold the titles?

CleanShot 2024-12-20 at 10 54 19@2x

  • can we expand the boxes to the full edge to match?
  • can we semi-bold the titles?
  • possible to add icons here above the titles?

CleanShot 2024-12-20 at 10 54 39@2x

  • can we update this to match the figma designs?
  • no dropdowns, expand each list by default
  • below is the suggested design styling

CleanShot 2024-12-20 at 10 59 03@2x

@briwylde08
Copy link
Contributor Author

Thanks @sdfcharles! A couple replies:

-Learn More is getting fixed in the latest commit, just noticed the lack of space
-We opted to not use icons because we don't want the page to be too "market-y", I've seen feedback that too many marketing assets is not necessarily welcome in developer docs, but would be more appropriate for stellar.org content
-I like the drop-downs, would be curious what @janewang and @ElliotFriend think about them versus expanded

@stellar-jenkins
Copy link

Preview is available here:
http://developers-pr1005.previews.kube001.services.stellar-ops.com

@janewang
Copy link
Contributor

no dropdowns, expand each list by default

+1 I think we should expand by default

@janewang
Copy link
Contributor

Nit: remove an extra row

Screenshot 2024-12-20 at 12 21 10 PM

@briwylde08
Copy link
Contributor Author

briwylde08 commented Dec 20, 2024 •
edited
Loading

Just for clarification: we want the sections to remain collapsible, just expanded by default? Or do we want to remove the collapsibility altogether? @janewang @sdfcharles edit: i just added default expansion

And I've tried to adjust the tables to remove that top bar but I can't figure out how tbh, it might be doable with more design work but it's not possible in Markdown as it's the title bar.

@ElliotFriend
Copy link
Contributor

I don't have very strong feelings one way or the other about the tables being expanded/collapsed/collapsible. But did notice a couple things about them:

  • the page seems quite long without them collapsed,
  • and the blue-on-blue that's happening with them is a little weird to my eye.

As for the padding on the edges and semi bold, i like that idea!

@stellar-jenkins
Copy link

Preview is available here:
http://developers-pr1005.previews.kube001.services.stellar-ops.com

@stellar-jenkins
Copy link

Preview is available here:
http://developers-pr1005.previews.kube001.services.stellar-ops.com

@briwylde08
Copy link
Contributor Author

@sdfcharles and @janewang - updates made! WDYT?

@sdfcharles
Copy link

@briwylde08 looks better, thanks for making those changes!

is there anyway to update these to have a white background instead?

CleanShot 2024-12-20 at 13 35 47@2x

@stellar-jenkins
Copy link

Something went wrong with PR preview build please check

@stellar-jenkins
Copy link

Something went wrong with PR preview build please check

@stellar-jenkins
Copy link

Preview is available here:
http://developers-pr1005.previews.kube001.services.stellar-ops.com

@briwylde08 briwylde08 merged commit dcddc98 into main Dec 20, 2024
2 checks passed
@briwylde08 briwylde08 deleted the homepage-wayfinding branch December 20, 2024 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chowbao chowbao chowbao left review comments

@janewang janewang janewang approved these changes

@sdfcharles sdfcharles Awaiting requested review from sdfcharles

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@briwylde08 @stellar-jenkins @sdfcharles @janewang @ElliotFriend @chowbao