Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update install instructions of the stellar-cli #1045

Merged
merged 1 commit into from
Oct 16, 2024

Conversation

leighmcculloch
Copy link
Member

@leighmcculloch leighmcculloch commented Oct 16, 2024

What

Update install instructions of the stellar-cli:

  • Remove cargo-binstall instructions
  • Elevate binary installs over source
  • Remove instructions for installing from the repo

Why

  • Remove cargo-binstall instructions
  • It breaks from time to time.
  • It's broken right now.
  • It installs from source without --locked which is not secure.
  • The tool doesn't verify github attestations, vs brew that does.
  • Issues about improving supply chain vulnerability are getting little attention.
  • Elevate binary installs over source
  • Building from source is time consuming and requires more than the rust compiler to be installed.
  • Building from source requires a significant amount of system resources.
  • Most folks will have a better experience installing a precompiled binary.
  • Remove instructions for installing from the repo
  • 99% of devs should be installing the latest release.
  • We're releasing more frequently lately and getting features out fast.

We still have a gap installing binaries for Windows, but we're on it and that is being tracked in:


Note that related to this, I've opened an issue on the stellar-cli repo to fix the issues above that are within our control. The change to the docs is because I don't think we should be pushing it as a preferred way to install ahead of other things like homebrew which has more attention to supply chain security.

@leighmcculloch leighmcculloch requested a review from fnando October 16, 2024 01:08
@stellar-jenkins
Copy link

@leighmcculloch leighmcculloch merged commit af0af63 into main Oct 16, 2024
2 checks passed
@leighmcculloch leighmcculloch deleted the remove-cargo-binstall branch October 16, 2024 02:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants