Remove incorrect stellar-cli instructions #1107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview is available here: |
1 similar comment
|
Preview is available here: |
|
Instead of removing the instructions, should we fix them instead by adding |
fnando
approved these changes
Dec 2, 2024
I don't think so. These docs are communicating the primary ways we want devs to use the tooling. I don't think we really want the majority of users running unreleased CLIs. Instead we should be releasing so often no one would need to use the unreleased CLIs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Remove incorrect stellar-cli instructions.
Why
The instructions say to use the cargo install command to install from the main branch, but the command won't do that, it'll install the latest released version. We already show a similar command above that for how to install the latest version (with the version specified), so we don't need to show it a second time without the version specified.
I also don't think we should promote how folks can install from the main branch. The main branch is unreleased and unstable. If folks really want to they can go and install from the main branch, but we don't need to place it front and centre as a recommended way to go.
The idea of building the main branch came about when the cli was releasing too infrequently. We're trying to, and are, releasing more frequently now.