Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix documentation signAndSend with kit.signTransaction #1119

Merged
merged 1 commit into from
Dec 10, 2024

Conversation

tupui
Copy link
Contributor

@tupui tupui commented Dec 9, 2024

See the following discussion https://discord.com/channels/897514728459468821/1315433251044724766

And I think linked to stellar/js-stellar-sdk#1113

With new versions of the JS SDK, the parameter signTransaction of signAndSend does not accept a string anymore but an object with 2 properties { signedTxXdr, signerAddress }.

This PR simplifies the example.

@Shaptic Shaptic merged commit 6043319 into stellar:main Dec 10, 2024
1 check passed
@tupui tupui deleted the fix/wallet_kit_sign branch December 10, 2024 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants