-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: update frontend tutorial to latest libs #1121
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
'Soroban template' doesn't feel specific enough and is also oddly over specific.
Soroban is the contract runtime. But a dapp / web app is primarily interacting with the Stellar network, not the contract runtime.
Templates could exist that don't use contracts at all too.
stellar-template
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point, @leighmcculloch. I think
stellar-template-*
is probably a better prefix.So far, these templates have been focused on interacting with smart contract projects, which is why we started with
soroban-template-*
.If we want to update this, we will need to update all the existing templates. These are mostly owned by @ElliotFriend. What do you think, Elliot?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did we consider using repo topics?
Repo topics are convenient because you can browse and search them on GitHub, where-as searching for repos with a particular prefix is harder / less accurate and will match on unrelated things.
For example:
https://github.com/topics/stellar
I think we could create a topic
stellar-template
:https://github.com/topics/stellar-template
Vs searching for repos with a particular prefix, which requires devs to have knowledge of GitHub search queries:
https://github.com/search?q=soroban-template-+in:name&type=repositories
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Another pro for repo topics is that any repo assigned a topic will have a little blue circle with the topic name in it on it's home page, which when folks click will take them to a browsable list of repos sorted by popularity that are also tagged with the topic. i.e. Repo topics are self discoverable.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know this conversation is a bit old at this point, sorry. I'm not very familiar with repo topics, but it sounds like that's an easier, more discoverable way to go. Maybe we can also recommend that
stellar-template-*
is a convention that's often used for templates?To the point @chadoh made, it does seem like something we could tackle in a subsequent PR
Edit: I've gone through my templates and added the following topics, for whatever it's worth.
soroban
,soroban-template
,soroban-template-frontend
,soroban-frontend-template
,stellar
,stellar-template
,stellar-template-frontend
,stellar-frontend-template
. Figured the shotgun approach might get all our bases covered lol