-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Building-Apps / Wallet: add Recovery SEP-30 instructions #261
Conversation
Something went wrong with PR preview build please check |
Preview is available here: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM except 1 comment
docs/building-apps/wallet/sep30.mdx
Outdated
|
||
</CodeExample> | ||
|
||
Next, we need to define SEP-30 identities. In this example we are going to use the same identity on both recovery servers. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you mind adding one more identity for the second server, using email? (just for clarity and because using same identity on both servers is an anti-pattern)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
like this? 85e9958
when I tried setting the identity with just email like this:
const identity2 = {
role: RecoveryRole.OWNER,
authMethods: [
{
type: RecoveryType.EMAIL,
value: "[email protected]",
},
],
};
I was getting a 404 with the recovery server when it gets to requesting a signature. From my understanding the recovery server identifies the account from the recoveryKey in the authToken right? Do you know how it should work when the identity is email only?
Preview is available here: |
Update outdated token terminology
ticket
Adds instructions for using the sep-30 recovery code in the wallet-sdk
moved a lot of the same instruction over from the kotlin sdk wallet guide