Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Building-Apps / Wallet: add Recovery SEP-30 instructions #261

Merged
merged 4 commits into from
Oct 31, 2023

Conversation

acharb
Copy link
Contributor

@acharb acharb commented Oct 30, 2023

ticket

Adds instructions for using the sep-30 recovery code in the wallet-sdk

moved a lot of the same instruction over from the kotlin sdk wallet guide

@stellar-jenkins
Copy link

Something went wrong with PR preview build please check

@stellar-jenkins
Copy link

Copy link
Contributor

@Ifropc Ifropc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except 1 comment


</CodeExample>

Next, we need to define SEP-30 identities. In this example we are going to use the same identity on both recovery servers.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you mind adding one more identity for the second server, using email? (just for clarity and because using same identity on both servers is an anti-pattern)

Copy link
Contributor Author

@acharb acharb Oct 30, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

like this? 85e9958

when I tried setting the identity with just email like this:

const identity2 = {
  role: RecoveryRole.OWNER,
  authMethods: [
    {
      type: RecoveryType.EMAIL,
      value: "[email protected]",
    },
  ],
};

I was getting a 404 with the recovery server when it gets to requesting a signature. From my understanding the recovery server identifies the account from the recoveryKey in the authToken right? Do you know how it should work when the identity is email only?

@stellar-jenkins
Copy link

@acharb acharb requested a review from Ifropc October 31, 2023 15:38
@acharb acharb merged commit 3146713 into main Oct 31, 2023
@acharb acharb deleted the acharb-recovery branch October 31, 2023 16:48
ElliotFriend pushed a commit that referenced this pull request Mar 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants