Add schema for signatures #466
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amishas157
commented
Jul 29, 2024
Comment on lines
+212
to
+215
| { | ||
| "mode": "REPEATED", | ||
| "name": "signatures", | ||
| "type": "STRING" |
There was a problem hiding this comment.
There is no alternative to ARRAY_CONTAINS in bigquery . I would leave it as is in that case. Converting to JSON may also not be helpful since there is no contains operator sadly. We would need to do unnest no matter what. :/
cc @chowbao
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
PR Structure
otherwise).
Thoroughness
What
This PR adds export of signatures field in history_transactions table.
Ref: stellar/stellar-etl#271
Why
Ref: stellar/stellar-etl#271
Known limitations
None. Signatures is added as repeated string. To use it downstream, we would need to unnest it. However, there are no alternatives of it.