Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add account of signer accounts when exporting transactions #468

Merged
merged 2 commits into from
Jul 30, 2024

Conversation

amishas157
Copy link
Contributor

@amishas157 amishas157 commented Jul 30, 2024

PR Checklist

PR Structure

  • This PR has reasonably narrow scope (if not, break it down into smaller PRs).
  • This PR avoids mixing refactoring changes with feature changes (split into two PRs
    otherwise).
  • This PR's title starts with the jira ticket associated with the PR.

Thoroughness

  • This PR adds tests for the most critical parts of the new functionality or fixes.
  • I've updated the README with the added features, breaking changes, new instructions on how to use the repository.

What

This PR exports transaction signers (account) instead of signatures themselves

Why

Ref stellar/stellar-etl#272

Known limitations

None

@amishas157 amishas157 marked this pull request as ready for review July 30, 2024 16:45
@amishas157 amishas157 requested a review from a team as a code owner July 30, 2024 16:45
@@ -211,7 +211,7 @@
},
{
"mode": "REPEATED",
"name": "signatures",
"name": "tx_signers",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI you might need to manually drop signatures from the table

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep. I have not deployed on prod. So good. Will drop on dev

@amishas157 amishas157 merged commit 29be552 into master Jul 30, 2024
2 checks passed
@sydneynotthecity sydneynotthecity deleted the find-accounts-of-signers branch November 21, 2024 03:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants