-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
State table verification #169
Open
lucaszanotelli
wants to merge
27
commits into
master
Choose a base branch
from
state_table_verification
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 18 commits
Commits
Show all changes
27 commits
Select commit
Hold shift + click to select a range
a8d105f
add verify library
lucaszanotelli 62ba8a5
add function to find if ledger is a checkpoint
lucaszanotelli c5f68eb
add captive core folder path to gitignore
lucaszanotelli 554d18f
add raw fields to trustline output
lucaszanotelli 1d5cd44
add raw fields to offer output
lucaszanotelli 1885219
add raw fields to account output
lucaszanotelli df333a5
add raw fields to claimable balance output
lucaszanotelli 62091d4
add raw fields to liquidity pool output
lucaszanotelli 8b2e3b5
create type for transformed outputs
lucaszanotelli 28ce0ac
testing verify implementation
lucaszanotelli 745b668
update tests
lucaszanotelli cbbc778
clear extra code from horizon
lucaszanotelli 76e2dfd
add header disclaimer
lucaszanotelli 20398ce
implement checkpoint ledgers verification
lucaszanotelli 314711c
revert transformed outputs to map
lucaszanotelli 955d127
remove comments
lucaszanotelli 0ea7ba6
change transformed output name
lucaszanotelli e4578e5
uncomment actual code
lucaszanotelli b34f1b7
go mod tidy
lucaszanotelli cf981ed
remove copies from horizon
lucaszanotelli 4c11faa
import verify module from monorepo
lucaszanotelli 39b6342
remove boolean output
lucaszanotelli 26adc61
add error verify to CreateHistoryArchiveClient
lucaszanotelli 58cf796
reduce verifyBatchSize 24000
lucaszanotelli f56645c
check if signer entry is deleted
lucaszanotelli 7360909
remove extra element check
lucaszanotelli 57e871f
verify if entry exists before comparison
lucaszanotelli File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you know where the
verifyBatchSize
comes from? Do we know that 50000 is big enough?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
verifyBatchSize
value came from here. About the second question, I don't know the answer. Maybe @bartekn could you help us with that?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This value can be changed. It's basically as big as possible but small enough to not cause OOM crash.