Add export all history command #220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
|
|
||
| outFileOperations.Close() | ||
| cmdLogger.Info("Number of bytes written: ", totalNumBytes) |
There was a problem hiding this comment.
If we get frequent transient errors, more logging that identifies which file/export process failed might be helpful. Since this is a temp fix, i'll leave it up to you whether that's worthwhile to add.
There was a problem hiding this comment.
Yeah it's probably not that useful. Any issue would more easily be resolved by running the original pipeline instead of this hack
Co-authored-by: sydneynotthecity <[email protected]>
I didn't run this in prod but in test it adds about 10s - 20s more time (so completes in 40s compared to 20s-30s). I think the runtime ratio will be much better in prod because the part that will benefit the most is the captive core catchup portion |
sydneynotthecity
approved these changes
Jan 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding temporary command
export_all_historyto mitigate the high egress costs hitting the history archives.This combines the export for operations, trades, effects, transactions, and diagnostic events to use only a single captive core instead of each spinning up their own for data export.
TODO: This should be removed as soon as LedgerExporter is complete and a TxMeta datalake is available