Update soroban fees #231
Merged
Update soroban fees #231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+251
to
+261
| if accountEntry.AccountId.Address() == sourceAccountAddress { | ||
| accountBalanceEnd = int64(accountEntry.Balance) | ||
| } | ||
| case xdr.LedgerEntryChangeTypeLedgerEntryState: | ||
| accountEntry, ok := change.State.Data.GetAccount() | ||
| if !ok { | ||
| continue | ||
| } | ||
|
|
||
| if accountEntry.AccountId.Address() == sourceAccountAddress { | ||
| accountBalanceStart = int64(accountEntry.Balance) |
There was a problem hiding this comment.
will this logic work with fee bump transactions as well?
There was a problem hiding this comment.
None of the above logic runs for a fee bump transaction. Right now it only looks at V1 transactions which can have sorobanData
Right now the fee for fee bump transactions is saved in max_fee. Do these fees need some breakdown as well?
There was a problem hiding this comment.
Updated to handle fee bump transactions as well. Although there aren't any in mainnet nor testnet so far
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
inclusion_fee_bid, inclusion_fee_charged, and resource_fee_refund