Add ledger_key_hash to history_operations
#237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
internal/transform/operation.go
Outdated
Comment on lines
1796
to
1801
| for _, ledgerKey := range transactionEnvelope.Tx.Ext.SorobanData.Resources.Footprint.ReadOnly { | ||
| ledgerKeyHash := utils.LedgerKeyToLedgerKeyHash(ledgerKey) | ||
| if ledgerKeyHash != "" { | ||
| return ledgerKeyHash | ||
| } | ||
| } |
There was a problem hiding this comment.
we just learned that restore/bump footprint ops will bump all keys in the footprint. Is it possible to store all keys in an array instead of saving only the first one?
There was a problem hiding this comment.
The last commit changes the ledgerKeyHashFromTxEnvelope function logic to store the ledger_key_hash in an array.
Here's an excerpt of an output from the export_operations command:
{
"closed_at": "2024-02-06T18:42:32Z",
"details": {
"asset_balance_changes": [],
"contract_code_hash": "4b9316721487281d8201e1c6044544400f120253487971e339eb23a465516935",
"contract_id": "CAJRV7IFJ35V7W3NYDAUCG3BPQM32SBRX2R3OX7HQGTUJWOMJCA7VFKF",
"function": "HostFunctionTypeHostFunctionTypeInvokeContract",
"ledger_key_hash": [
"980ea3840d17b86222a52d923a03cf9e918bd9851c00c0dd20a5f13aac18e523",
"493f4eee738cf139a9d7690b355a0ce57f4bf36b489048edead7d1eba97a74e6",
"8de7eeb5332495ed271a11d1849fc6f5ec970c73ca9cb5eb1a57126c4a278f56"
],
"parameters": [
{
"type": "Address",
"value": "AAAAEgAAAAETGv0FTvtf223AwUEbYXwZvUgxvqO3X+eBp0TZzEiB+g=="
}...Does that sound acceptable?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a new field named
ledger_key_hashto thehistory_operationsexport file. The field will only be included when the OperationType property is one of the following values:InvokeHostFunctionExtendFootprintTtlRestoreFootprint