-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the document to backfill using tx_meta #273
Add the document to backfill using tx_meta #273
Conversation
Steps outlined in the document added in this PR. I will add screenshots and links for confirming test results Library in GCS bucketJS UDFhttps://console.cloud.google.com/bigquery?ws=!1m7!1m6!12m5!1m3!1stest-hubble-319619!2sus-central1!3s834c1d13-e58e-40ff-90ec-a7435ec4fe42!2e1 Results confirmations:Sample check against horizon (testnet) ✅
Next steps:
|
backfill.md
Outdated
) | ||
AS r""" | ||
let txe = StellarBase.xdr.TransactionEnvelope.fromXDR(tx_meta, 'base64'); | ||
let tx = txe.feeBump(); | ||
let sourceAccount = StellarBase.encodeMuxedAccountToAddress(tx.tx().feeSource()); | ||
return sourceAccount | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Shaptic for the helps here 🙌
lint pass?
19d575e
to
ea28305
Compare
backfill.md
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice!
Do you think we should make a new directory for this .md? It seems misplaced in the base directory. Maybe like a notes
or scripts
directory? Open to naming ideas
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
docs/
? I am also thinking to include migrations
directory, where we manually track any udfs run we apply
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yup I like that idea
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
backfill.md
Outdated
|
||
Following is example to extract FeeAccountMuxed: | ||
|
||
``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggestion: add javascript
tag here for syntax highlighting
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Addressed in d5884a2
backfill.md
Outdated
let txe = StellarBase.xdr.TransactionEnvelope.fromXDR(tx_meta, 'base64'); | ||
let tx = txe.feeBump(); | ||
let sourceAccount = StellarBase.encodeMuxedAccountToAddress(tx.tx().feeSource()); | ||
return sourceAccount |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let txe = StellarBase.xdr.TransactionEnvelope.fromXDR(tx_meta, 'base64'); | |
let tx = txe.feeBump(); | |
let sourceAccount = StellarBase.encodeMuxedAccountToAddress(tx.tx().feeSource()); | |
return sourceAccount | |
return StellarBase.encodeMuxedAccountToAddress( | |
StellarBase.xdr.TransactionEnvelope.fromXDR(tx_meta, 'base64') | |
.feeBump() | |
.tx() | |
.feeSource() | |
); |
😉
PR Checklist
PR Structure
otherwise).
Thoroughness
Release planning
semver, and I've changed the name of the BRANCH to release/_ , feature/_ or patch/* .
What
This PR add instructions on backfill historical data using tx_meta
Why
Airflow runs can be time and money consuming. To ease up the migrations, JS UDF can be convenient.
Known limitations
To be figures: Cost of UDF (they should be cheap most likely)