Fix logging issues in stellar-etl writing to airflow #281
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
PR Structure
otherwise).
Thoroughness
Release planning
semver, and I've changed the name of the BRANCH to release/_ , feature/_ or patch/* .
What
Updated some of the cmdLogger message types to error out properly when running stellar-etl in airflow.
cmdLogger.Error/Errorf
does not actually return a status as failure from airflow's perspective. So these "errors" don't mark an airflow task as a failure. Only when anError
is coupled withcmdLogger.LogError
orcmdLogger.Fatal/Fatalf
will the airflow task be marked as failed.Why
Fix the logging issues when running stellar-etl in airflow.
Known limitations
N/A