Add both versions of getVersionInfo in, change type of createdAt

stellar · Oct 24, 2024 · 54e3360 · 54e3360
1 parent a26c6be
commit 54e3360
Show file tree

Hide file tree

Showing 3 changed files with 20 additions and 7 deletions.
diff --git a/cmd/soroban-rpc/internal/methods/get_events.go b/cmd/soroban-rpc/internal/methods/get_events.go
@@ -337,7 +337,8 @@ type PaginationOptions struct {
 type GetEventsResponse struct {
 	Events       []EventInfo `json:"events"`
 	LatestLedger uint32      `json:"latestLedger"`
-	// Cursor represents last populated event ID if total events reach the limit or end of the search window
+	// Cursor represents last populated event ID if total events reach the limit
+	// or end of the search window
 	Cursor string `json:"cursor"`
 }
 

diff --git a/cmd/soroban-rpc/internal/methods/get_transactions.go b/cmd/soroban-rpc/internal/methods/get_transactions.go
@@ -82,7 +82,7 @@ type TransactionInfo struct {
 	// Ledger is the sequence of the ledger which included the transaction.
 	Ledger uint32 `json:"ledger"`
 	// LedgerCloseTime is the unix timestamp of when the transaction was included in the ledger.
-	LedgerCloseTime int64 `json:"createdAt,string"`
+	LedgerCloseTime int64 `json:"createdAt"`
 }
 
 // GetTransactionsResponse encapsulates the response structure for getTransactions queries.

diff --git a/cmd/soroban-rpc/internal/methods/get_version_info.go b/cmd/soroban-rpc/internal/methods/get_version_info.go
@@ -19,6 +19,14 @@ type GetVersionInfoResponse struct {
 	BuildTimestamp     string `json:"buildTimestamp"`
 	CaptiveCoreVersion string `json:"captiveCoreVersion"`
 	ProtocolVersion    uint32 `json:"protocolVersion"`
+	//nolint:tagliatelle
+	CommitHashDeprecated string `json:"commit_hash"`
+	//nolint:tagliatelle
+	BuildTimestampDeprecated string `json:"build_timestamp"`
+	//nolint:tagliatelle
+	CaptiveCoreVersionDeprecated string `json:"captive_core_version"`
+	//nolint:tagliatelle
+	ProtocolVersionDeprecated uint32 `json:"protocol_version"`
 }
 
 func NewGetVersionInfoHandler(
@@ -37,11 +45,15 @@ func NewGetVersionInfoHandler(
 		}
 
 		return GetVersionInfoResponse{
-			Version:            config.Version,
-			CommitHash:         config.CommitHash,
-			BuildTimestamp:     config.BuildTimestamp,
-			CaptiveCoreVersion: captiveCoreVersion,
-			ProtocolVersion:    protocolVersion,
+			Version:                      config.Version,
+			CommitHash:                   config.CommitHash,
+			CommitHashDeprecated:         config.CommitHash,
+			BuildTimestamp:               config.BuildTimestamp,
+			BuildTimestampDeprecated:     config.BuildTimestamp,
+			CaptiveCoreVersion:           captiveCoreVersion,
+			CaptiveCoreVersionDeprecated: captiveCoreVersion,
+			ProtocolVersion:              protocolVersion,
+			ProtocolVersionDeprecated:    protocolVersion,
 		}, nil
 	})
 }