Revert "soroban-rpc: Remove publish-dry-run Workflow (#63)"

This reverts commit 8d16b4b.
stellar · Feb 21, 2024 · a88a7c9 · a88a7c9
1 parent 1a4f5c8
commit a88a7c9
Show file tree

Hide file tree

Showing 2 changed files with 50 additions and 9 deletions.
diff --git a/.github/workflows/golangci-lint.yml b/.github/workflows/golangci-lint.yml
@@ -28,14 +28,13 @@ jobs:
           rustup update
           make build-libpreflight
 
-      # Disable this for now since this workflow ignores golangci-lint failures anyway (i.e. --issues-exit-code=0) 
-      # - name: Run golangci-lint
-      #   uses: golangci/golangci-lint-action@537aa1903e5d359d0b27dbc19ddd22c5087f3fbc # version v3.2.0
-      #   with:
-      #     version: v1.51.1 # this is the golangci-lint version
-      #     args: --issues-exit-code=0 # exit without errors for now - won't fail the build
-      #     github-token: ${{ secrets.GITHUB_TOKEN }}
-      #     only-new-issues: true
+      - name: Run golangci-lint
+        uses: golangci/golangci-lint-action@537aa1903e5d359d0b27dbc19ddd22c5087f3fbc # version v3.2.0
+        with:
+          version: v1.51.1 # this is the golangci-lint version
+          args: --issues-exit-code=0 # exit without errors for now - won't fail the build
+          github-token: ${{ secrets.GITHUB_TOKEN }}
+          only-new-issues: true
 
 
 

diff --git a/.github/workflows/rust.yml b/.github/workflows/rust.yml
@@ -13,7 +13,7 @@ jobs:
 
   complete:
     if: always()
-    needs: [fmt, rust-analyzer-compat, build-and-test]
+    needs: [fmt, rust-analyzer-compat, build-and-test, publish-dry-run]
     runs-on: ubuntu-latest
     steps:
     - if: contains(needs.*.result, 'failure') || contains(needs.*.result, 'cancelled')
@@ -80,3 +80,45 @@ jobs:
         for I in cmd/crates/* ; do
           cargo test --target ${{ matrix.target }} --manifest-path $I/Cargo.toml
         done
+
+  publish-dry-run:
+    if: github.event_name == 'push' || startsWith(github.head_ref, 'release/')
+    strategy:
+      fail-fast: false
+      matrix:
+        include:
+        - os: ubuntu-latest
+          target: x86_64-unknown-linux-gnu
+          cargo-hack-feature-options: --feature-powerset
+        - os: ubuntu-latest
+          target: aarch64-unknown-linux-gnu
+          cargo-hack-feature-options: --feature-powerset
+        - os: macos-latest
+          target: x86_64-apple-darwin
+          cargo-hack-feature-options: --feature-powerset
+        - os: macos-latest
+          target: aarch64-apple-darwin
+          cargo-hack-feature-options: --feature-powerset
+        # Windows builds notes:
+        #
+        # The different features that need testing are split over unique
+        # isolated builds for Windows, because there's a bug in Cargo [1] that
+        # causes builds of wasm-opt [2] to fail when run one after the other and
+        # attempting to clean up artifacts in between. The bug has been fixed,
+        # but will not make it into a stable release of Cargo until ~August
+        # 2023.
+        #
+        # [1]: https://github.com/rust-lang/cargo/pull/11442
+        # [2]: https://github.com/brson/wasm-opt-rs/issues/116
+        - os: windows-latest-8-cores
+          target: x86_64-pc-windows-msvc
+          cargo-hack-feature-options: ''
+        - os: windows-latest-8-cores
+          target: x86_64-pc-windows-msvc
+          cargo-hack-feature-options: --features opt --ignore-unknown-features
+    uses: stellar/actions/.github/workflows/rust-publish-dry-run-v2.yml@main
+    with:
+      crates: soroban-test
+      runs-on: ${{ matrix.os }}
+      target: ${{ matrix.target }}
+      cargo-hack-feature-options: ${{ matrix.cargo-hack-feature-options }}