Change ledger sequence to uint32

stellar · Apr 18, 2024 · aeb0a84 · aeb0a84
1 parent 364ee92
commit aeb0a84
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 9 deletions.
diff --git a/cmd/soroban-rpc/internal/methods/get_transactions.go b/cmd/soroban-rpc/internal/methods/get_transactions.go
@@ -60,7 +60,7 @@ type TransactionInfo struct {
 	FeeBump          bool   `json:"feeBump"`
 	ApplicationOrder int32  `json:"applicationOrder"`
 	Successful       bool   `json:"successful"`
-	LedgerSequence   uint   `json:"ledgerSequence"`
+	LedgerSequence   uint32 `json:"ledgerSequence"`
 }
 
 // GetTransactionsResponse encapsulates the response structure for getTransactions queries.
@@ -180,7 +180,7 @@ LedgerLoop:
 				FeeBump:          tx.Envelope.IsFeeBump(),
 				ApplicationOrder: int32(tx.Index),
 				Successful:       tx.Result.Result.Successful(),
-				LedgerSequence:   uint(ledger.LedgerSequence()),
+				LedgerSequence:   ledger.LedgerSequence(),
 			}
 
 			txns = append(txns, txInfo)

diff --git a/cmd/soroban-rpc/internal/test/get_transactions_test.go b/cmd/soroban-rpc/internal/test/get_transactions_test.go
@@ -83,9 +83,9 @@ func TestGetTransactions(t *testing.T) {
 	err := client.CallResult(context.Background(), "getTransactions", request, &result)
 	assert.NoError(t, err)
 	assert.Equal(t, len(result.Transactions), 3)
-	assert.Equal(t, uint32(result.Transactions[0].LedgerSequence), ledgers[0])
-	assert.Equal(t, uint32(result.Transactions[1].LedgerSequence), ledgers[1])
-	assert.Equal(t, uint32(result.Transactions[2].LedgerSequence), ledgers[2])
+	assert.Equal(t, result.Transactions[0].LedgerSequence, ledgers[0])
+	assert.Equal(t, result.Transactions[1].LedgerSequence, ledgers[1])
+	assert.Equal(t, result.Transactions[2].LedgerSequence, ledgers[2])
 
 	// Get transactions from single ledger
 	request = methods.GetTransactionsRequest{
@@ -95,7 +95,7 @@ func TestGetTransactions(t *testing.T) {
 	err = client.CallResult(context.Background(), "getTransactions", request, &result)
 	assert.NoError(t, err)
 	assert.Equal(t, len(result.Transactions), 1)
-	assert.Equal(t, uint32(result.Transactions[0].LedgerSequence), ledgers[0])
+	assert.Equal(t, result.Transactions[0].LedgerSequence, ledgers[0])
 
 	// Get transactions with limit
 	request = methods.GetTransactionsRequest{
@@ -108,7 +108,7 @@ func TestGetTransactions(t *testing.T) {
 	err = client.CallResult(context.Background(), "getTransactions", request, &result)
 	assert.NoError(t, err)
 	assert.Equal(t, len(result.Transactions), 1)
-	assert.Equal(t, uint32(result.Transactions[0].LedgerSequence), ledgers[0])
+	assert.Equal(t, result.Transactions[0].LedgerSequence, ledgers[0])
 
 	// Get transactions using previous result's cursor
 	cursor := result.Pagination.Cursor
@@ -122,7 +122,7 @@ func TestGetTransactions(t *testing.T) {
 	err = client.CallResult(context.Background(), "getTransactions", request, &result)
 	assert.NoError(t, err)
 	assert.Equal(t, len(result.Transactions), 2)
-	assert.Equal(t, uint32(result.Transactions[0].LedgerSequence), ledgers[1])
-	assert.Equal(t, uint32(result.Transactions[1].LedgerSequence), ledgers[2])
+	assert.Equal(t, result.Transactions[0].LedgerSequence, ledgers[1])
+	assert.Equal(t, result.Transactions[1].LedgerSequence, ledgers[2])
 
 }