Add txHash field to getTransaction after upstream merge (#314)

stellar · Oct 29, 2024 · bb6c594 · bb6c594
1 parent 5932852
commit bb6c594
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/cmd/soroban-rpc/internal/methods/get_transaction.go b/cmd/soroban-rpc/internal/methods/get_transaction.go
@@ -100,6 +100,7 @@ func GetTransaction(
 		OldestLedger:          storeRange.FirstLedger.Sequence,
 		OldestLedgerCloseTime: storeRange.FirstLedger.CloseTime,
 	}
+	response.TransactionHash = request.Hash
 	if errors.Is(err, db.ErrNoTransaction) {
 		response.Status = TransactionStatusNotFound
 		return response, nil

diff --git a/cmd/soroban-rpc/internal/methods/get_transaction_test.go b/cmd/soroban-rpc/internal/methods/get_transaction_test.go
@@ -37,7 +37,8 @@ func TestGetTransaction(t *testing.T) {
 	require.NoError(t, err)
 	require.Equal(t, GetTransactionResponse{
 		TransactionDetails: TransactionDetails{
-			Status: TransactionStatusNotFound,
+			Status:          TransactionStatusNotFound,
+			TransactionHash: hash,
 		},
 	}, tx)
 
@@ -64,6 +65,7 @@ func TestGetTransaction(t *testing.T) {
 			Status:              TransactionStatusSuccess,
 			ApplicationOrder:    1,
 			FeeBump:             false,
+			TransactionHash:     hash,
 			EnvelopeXDR:         expectedEnvelope,
 			ResultXDR:           expectedTxResult,
 			ResultMetaXDR:       expectedTxMeta,
@@ -88,6 +90,7 @@ func TestGetTransaction(t *testing.T) {
 		TransactionDetails: TransactionDetails{
 			Status:              TransactionStatusSuccess,
 			ApplicationOrder:    1,
+			TransactionHash:     hash,
 			FeeBump:             false,
 			EnvelopeXDR:         expectedEnvelope,
 			ResultXDR:           expectedTxResult,
@@ -120,6 +123,7 @@ func TestGetTransaction(t *testing.T) {
 			Status:              TransactionStatusFailed,
 			ApplicationOrder:    1,
 			FeeBump:             false,
+			TransactionHash:     hash,
 			EnvelopeXDR:         expectedEnvelope,
 			ResultXDR:           expectedTxResult,
 			ResultMetaXDR:       expectedTxMeta,
@@ -155,6 +159,7 @@ func TestGetTransaction(t *testing.T) {
 			Status:              TransactionStatusSuccess,
 			ApplicationOrder:    1,
 			FeeBump:             false,
+			TransactionHash:     hash,
 			EnvelopeXDR:         expectedEnvelope,
 			ResultXDR:           expectedTxResult,
 			ResultMetaXDR:       expectedTxMeta,