stellar-rpc-client: Use objects as parameters in every call #125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2opremio
force-pushed
the
rpc-client-object-params
branch
from
f025999 to
5565969
Compare
2opremio
force-pushed
the
rpc-client-object-params
branch
from
5565969 to
287aba2
Compare
leighmcculloch
approved these changes
Apr 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Modify the stellar RPC client Rurst crate to use objects as parameters in every call
Why
Part of #121 . We need to update the CLI first for system tests to pass. Also, it's a good idea to release an updated CLI version first, to allow users to upgrade before disallowing array parameters for good.
Known limitations
N/A