Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve startup logging #127

Merged
merged 1 commit into from
Apr 9, 2024
Merged

Improve startup logging #127

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 30 additions & 8 deletions cmd/soroban-rpc/internal/daemon/daemon.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,10 +34,11 @@ import (
)

const (
prometheusNamespace = "soroban_rpc"
maxLedgerEntryWriteBatchSize = 150
defaultReadTimeout = 5 * time.Second
defaultShutdownGracePeriod = 10 * time.Second
prometheusNamespace = "soroban_rpc"
maxLedgerEntryWriteBatchSize = 150
defaultReadTimeout = 5 * time.Second
defaultShutdownGracePeriod = 10 * time.Second
inMemoryInitializationLedgerLogPeriod = 1_000_000
)

type Daemon struct {
Expand Down Expand Up @@ -137,6 +138,11 @@ func MustNew(cfg *config.Config) *Daemon {
logger.UseJSONFormatter()
}

logger.WithFields(supportlog.F{
"version": config.Version,
"commit": config.CommitHash,
}).Info("starting Soroban RPC")

core, err := newCaptiveCore(cfg, logger)
if err != nil {
logger.WithError(err).Fatal("could not create captive core")
Expand Down Expand Up @@ -196,7 +202,20 @@ func MustNew(cfg *config.Config) *Daemon {
// NOTE: We could optimize this to avoid unnecessary ingestion calls
// (the range of txmetads can be larger than the store retention windows)
// but it's probably not worth the pain.
var initialSeq uint32
var currentSeq uint32
err = db.NewLedgerReader(dbConn).StreamAllLedgers(readTxMetaCtx, func(txmeta xdr.LedgerCloseMeta) error {
currentSeq = txmeta.LedgerSequence()
if initialSeq == 0 {
initialSeq = currentSeq
logger.WithFields(supportlog.F{
"seq": currentSeq,
}).Info("initializing in-memory store")
} else if (currentSeq-initialSeq)%inMemoryInitializationLedgerLogPeriod == 0 {
2opremio marked this conversation as resolved.
Show resolved Hide resolved
logger.WithFields(supportlog.F{
"seq": currentSeq,
}).Debug("still initializing in-memory store")
}
if err := eventStore.IngestEvents(txmeta); err != nil {
logger.WithError(err).Fatal("could not initialize event memory store")
}
Expand All @@ -205,6 +224,11 @@ func MustNew(cfg *config.Config) *Daemon {
}
return nil
})
if currentSeq != 0 {
logger.WithFields(supportlog.F{
"seq": currentSeq,
}).Info("finished initializing in-memory store")
}
if err != nil {
logger.WithError(err).Fatal("could not obtain txmeta cache from the database")
}
Expand Down Expand Up @@ -285,10 +309,8 @@ func MustNew(cfg *config.Config) *Daemon {

func (d *Daemon) Run() {
d.logger.WithFields(supportlog.F{
"version": config.Version,
"commit": config.CommitHash,
"addr": d.server.Addr,
}).Info("starting Soroban JSON RPC server")
"addr": d.server.Addr,
}).Info("starting HTTP server")

panicGroup := util.UnrecoverablePanicGroup.Log(d.logger)
panicGroup.Go(func() {
Expand Down
Loading