Pass bucket list size from meta to simulation NetworkConfig.
#129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unfortunately, Core currently doesn't emit the bucket list size config entry changes in the meta, so the only way to fetch the proper value as of now is to use the meta field directly.
leighmcculloch
approved these changes
Apr 9, 2024
|
Are the updated dependencies based off protocol 20 or 21? (e.g. XDR-wise) |
The dependencies here were protocol 20 (the bump was necessary due to meta extension changes). But since we have decided to only include the fix with v21 env release, the deps in this PR don't make much sense. So I guess you could patch the code (but not dependency) changes from this PR into the PR that would do the 20->21 transition. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Pass bucket list size from meta to
NetworkConfig.Why
Unfortunately, Core currently doesn't emit the bucket list size config entry changes in the meta, so the only way to fetch the proper value as of now is to use the meta field directly.
Known limitations
N/A