Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctly report row iteration errors in StreamAllLedgers #168

Merged
merged 1 commit into from
May 10, 2024

Conversation

2opremio
Copy link
Contributor

What

Correctly report row iteration errors in StreamAllLedgers()

Also, clean up logging ordering.

Why

We were missing row iteration errors.

Closes #166

Known limitations

N/A

Also, improve in-memory loading logs.
@2opremio 2opremio merged commit 110ed20 into main May 10, 2024
20 checks passed
@2opremio 2opremio deleted the report-stream-all-ledgers-err branch May 10, 2024 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ingestion fails with ledgers not contiguous
2 participants