Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recompile the test contract from the CLI repo #184

Closed
wants to merge 2 commits into from

Conversation

Shaptic
Copy link
Contributor

@Shaptic Shaptic commented May 16, 2024

What

Checked out soroban-cli, went to

cd cmd/crates/soroban-test/tests/fixtures/test-wasms/hello_world
cargo build --target wasm32-unknown-unknown --release

and copied the resulting wasm file from /target/ here.

Why

Gotta keep it in sync so integration tests are accurate.

Known limitations

Doing this manually is annoying.

@Shaptic Shaptic closed this May 17, 2024
@Shaptic
Copy link
Contributor Author

Shaptic commented May 17, 2024

We'll need to actually update tests since the optimized WASM stuff makes it perform differently, I think, so it's not just a binary update.

@willemneal
Copy link
Member

@leighmcculloch Perhaps we could move contract build into it's own crate? This way it could be used here as well to build contracts consistently and perhaps also include the test contracts.

@leighmcculloch
Copy link
Member

leighmcculloch commented May 20, 2024

@willemneal It doesn't really matter if the special contract build is used or if cargo build is used in this context. The contract build process is only important for deployments for reducing wasm size, and even then only for specific crate setups, and it's easily reproducible using a cargo command. So I'm not sure the value is significant and worth the cost of breaking the build command out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants