Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add workaround for captive core bug in integration tests #223

Merged
merged 2 commits into from
Jun 18, 2024

Conversation

2opremio
Copy link
Contributor

@2opremio 2opremio commented Jun 18, 2024

Add a workaround for stellar/go#5342 , which is causing a race in integration tests.

See an instance of the problem at: https://github.com/stellar/soroban-rpc/actions/runs/9569819968/job/26383651448#step:10:110

 panic: Log in goroutine after TestArchiveUserAgent has completed: rpc="daemon" time="2024-06-18T17:58:16.017Z" level=info msg="\"peers\" : {" pid=16789 subservice=stellar-core


goroutine 13169 [running]:
testing.(*common).logDepth(0xc0006841a0, {0xc011bfe460, 0x6e}, 0x3)
	/opt/hostedtoolcache/go/1.22.4/x64/src/testing/testing.go:1028 +0x6d4
testing.(*common).log(...)
	/opt/hostedtoolcache/go/1.22.4/x64/src/testing/testing.go:1010
testing.(*common).Log(0xc0006841a0, {0xc0183379e8, 0x1, 0x1})
	/opt/hostedtoolcache/go/1.22.4/x64/src/testing/testing.go:1051 +0x7e
github.com/stellar/soroban-rpc/cmd/soroban-rpc/internal/integrationtest/infrastructure.testLogWriter.Write({0xc0006841a0?, {0x26ca1ce?, 0xc018337878?}}, {0xc005174700, 0x61, 0x0?})
	/home/runner/work/soroban-rpc/soroban-rpc/cmd/soroban-rpc/internal/integrationtest/infrastructure/test.go:409 +0x115
github.com/sirupsen/logrus.(*Entry).write(0xc00cac8b60)
	/home/runner/go/pkg/mod/github.com/sirupsen/[email protected]/entry.go:294 +0x269
github.com/sirupsen/logrus.(*Entry).log(0xc016bd8000, 0x4, {0xc005a96245, 0xb})
	/home/runner/go/pkg/mod/github.com/sirupsen/[email protected]/entry.go:252 +0xa6b
github.com/sirupsen/logrus.(*Entry).Log(0xc016bd8000, 0x4, {0xc018337e20, 0x1, 0x1})
	/home/runner/go/pkg/mod/github.com/sirupsen/[email protected]/entry.go:304 +0x8c
github.com/sirupsen/logrus.(*Entry).Info(...)
	/home/runner/go/pkg/mod/github.com/sirupsen/[email protected]/entry.go:321
github.com/stellar/go/support/log.(*Entry).Info(...)
	/home/runner/go/pkg/mod/github.com/stellar/[email protected]/support/log/entry.go:138
github.com/stellar/go/ingest/ledgerbackend.(*stellarCoreRunner).getLogLineWriter.func1()
	/home/runner/go/pkg/mod/github.com/stellar/[email protected]/ingest/ledgerbackend/stellar_core_runner.go:256 +0xa5d
created by github.com/stellar/go/ingest/ledgerbackend.(*stellarCoreRunner).getLogLineWriter in goroutine 13132
	/home/runner/go/pkg/mod/github.com/stellar/[email protected]/ingest/ledgerbackend/stellar_core_runner.go:221 +0x411
FAIL	github.com/stellar/soroban-rpc/cmd/soroban-rpc/internal/integrationtest	150.765s
FAIL

@2opremio 2opremio force-pushed the workaround-race-itests branch from 719110f to 726fca5 Compare June 18, 2024 18:37
@2opremio 2opremio changed the title Add workaround for captive code bug in integration tests Add workaround for captive core bug in integration tests Jun 18, 2024
Add a workaround for stellar/go#5342 ,
which is causing a race in integration tests.
@2opremio 2opremio force-pushed the workaround-race-itests branch from 726fca5 to b9a7e02 Compare June 18, 2024 19:02
@2opremio 2opremio merged commit 37d5060 into stellar:main Jun 18, 2024
19 checks passed
@2opremio 2opremio deleted the workaround-race-itests branch June 18, 2024 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants