Fix typo from #237 #238
Merged
Fix typo from #237 #238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I didn't adapt the logic right.
This was hard to debug because, in integration tests, it caused the
daemon to run `d.logger.WithError(err).Fatal("could not build
migrations")`, which in turn runs `os.Exit` which ends the test right
away (without flushing logs etc).
I need to think how to improve this. One option is to
override the `ExitFunc` in logrus with an assertion.
2opremio
force-pushed
the
fix-integration-tests
branch
from
6ad1e61 to
03507be
Compare
This reverts commit 0be1cd6.
mollykarcher
approved these changes
Jul 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I didn't adapt the logic right.
This was hard to debug because, in integration tests, it caused the daemon to run
d.logger.WithError(err).Fatal("could not build migrations"), which in turn runsos.Exitwhich ends the test right away (without flushing logs etc).I need to think how to improve this. One option is to override the
ExitFuncin logrus with an assertion.See #237 (comment)