Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CI concurrency group for some workflows #255

Merged
merged 1 commit into from
Jul 25, 2024

Conversation

mollykarcher
Copy link
Contributor

What

Add CI concurrency group limiting to one build per branch, canceling any older runs.

Why

See discussion here. Goal is to reduce cost and limit CI resource usage. This change will make it so that CI runs are canceled when new commits are pushed, except on protected branches (ex. main)

Note that the only workflow that is actually costing us money is e2e. Since this repo is public, all workflows that run on standard github runners (which is everything else) are free. So if for some reason we still want/like the runs for the other workflows to keep going when new commits are pushed, we could eliminate the changes there and just keep the e2e workflow changes.

@mollykarcher mollykarcher requested review from Shaptic and 2opremio July 24, 2024 18:02
Copy link
Contributor

@Shaptic Shaptic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should've checked this by pushing some fixup commits 😝 LGTM though!

@mollykarcher
Copy link
Contributor Author

You should've checked this by pushing some fixup commits 😝 LGTM though!

Yeah good call, we gucci

image
https://github.com/stellar/soroban-rpc/actions/runs/10081693493

@mollykarcher mollykarcher force-pushed the molly/main/concurrency branch from b6eb528 to 57cd06e Compare July 24, 2024 18:56
@mollykarcher mollykarcher merged commit ee27f46 into stellar:main Jul 25, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants