Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update images to latest Core references, drop P20 runs #273

Closed
wants to merge 4 commits into from
Closed

Update images to latest Core references, drop P20 runs #273

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b95d67a
Update images to latest Core references, drop P20 runs
Shaptic Aug 20, 2024
37ebc32
Merge branch 'main' into bump-latest-core
Shaptic Aug 27, 2024
c3417d0
Change upgrade test to do 21 -> 22, instead
Shaptic Aug 27, 2024
e91ab25
Merge branch 'bump-latest-core' of github.com:stellar/soroban-rpc int…
Shaptic Aug 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 3 additions & 5 deletions .github/workflows/soroban-rpc.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,16 +98,14 @@ jobs:
strategy:
matrix:
os: [ ubuntu-20.04, ubuntu-22.04 ]
protocol-version: [ 20, 21 ]
protocol-version: [ 21 ]
runs-on: ${{ matrix.os }}
env:
SOROBAN_RPC_INTEGRATION_TESTS_ENABLED: true
SOROBAN_RPC_INTEGRATION_TESTS_CORE_MAX_SUPPORTED_PROTOCOL: ${{ matrix.protocol-version }}
SOROBAN_RPC_INTEGRATION_TESTS_CAPTIVE_CORE_BIN: /usr/bin/stellar-core
PROTOCOL_20_CORE_DEBIAN_PKG_VERSION: 21.1.0-1909.rc1.b3aeb14cc.focal
PROTOCOL_20_CORE_DOCKER_IMG: stellar/stellar-core:21.1.0-1909.rc1.b3aeb14cc.focal
PROTOCOL_21_CORE_DEBIAN_PKG_VERSION: 21.1.0-1909.rc1.b3aeb14cc.focal
PROTOCOL_21_CORE_DOCKER_IMG: stellar/stellar-core:21.1.0-1909.rc1.b3aeb14cc.focal
PROTOCOL_21_CORE_DEBIAN_PKG_VERSION: 21.3.1-2006.4ede19620.focal
PROTOCOL_21_CORE_DOCKER_IMG: stellar/unsafe-stellar-core:21.3.1-2006.4ede19620.focal
steps:
- uses: actions/checkout@v4
with:
Expand Down
18 changes: 10 additions & 8 deletions cmd/soroban-rpc/internal/integrationtest/upgrade_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,20 +13,22 @@ import (
"github.com/stellar/soroban-rpc/cmd/soroban-rpc/internal/integrationtest/infrastructure"
)

func TestUpgradeFrom20To21(t *testing.T) {
if infrastructure.GetCoreMaxSupportedProtocol() != 21 {
t.Skip("Only test this for protocol 21")
func TestUpgradeFrom20To22(t *testing.T) {
if infrastructure.GetCoreMaxSupportedProtocol() != 22 {
t.Skip("Only test this for protocol 22")
}
test := infrastructure.NewTest(t, &infrastructure.TestConfig{
ProtocolVersion: 20,
ProtocolVersion: 21,
})

test.UploadHelloWorldContract()

// Upgrade to protocol 21 and re-upload the contract, which should cause a caching of the contract
// estimations
test.UpgradeProtocol(21)
// Wait for the ledger to advance, so that the simulation library passes the right protocol number
// Upgrade to protocol 21 and re-upload the contract, which should cause a
// caching of the contract estimations
test.UpgradeProtocol(22)

// Wait for the ledger to advance, so that the simulation library passes the
// right protocol number
rpcDB := test.GetDaemon().GetDB()
initialLedgerSequence, err := db.NewLedgerEntryReader(rpcDB).GetLatestLedgerSequence(context.Background())
require.NoError(t, err)
Expand Down
Loading