Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clamp cursors to the maximum int32 range to ensure validity #328

Closed
wants to merge 3 commits into from
Closed

Clamp cursors to the maximum int32 range to ensure validity #328

wants to merge 3 commits into from

Conversation

Shaptic
Copy link
Contributor

@Shaptic Shaptic commented Nov 13, 2024 •
edited
Loading

What

Clamp cursors on [0, MaxInt32].

Why

We never want to generate invalid cursors since we use them in DB queries. Related: #325.

Known limitations

n/a

I'd like to move clamp to our support/ordered later, too.

@Shaptic Shaptic requested review from tamirms, 2opremio and a team November 13, 2024 22:56
@Shaptic Shaptic closed this Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tamirms tamirms Awaiting requested review from tamirms

@2opremio 2opremio Awaiting requested review from 2opremio

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Shaptic