Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump e2e test protocol number and dependencies #342

Merged
merged 1 commit into from
Jan 9, 2025

Conversation

2opremio
Copy link
Contributor

No description provided.

@2opremio
Copy link
Contributor Author

@sreuland would you mind taking a look at the system-test's it seems like they need to be updated to support protocol 22 (or at least a more recent version of the JS SDK)

I am getting the following error:

 /home/tester/.nvm/versions/node/v18.19.0/lib/node_modules/ts-node/src/index.ts:859
    return new TSError(diagnosticText, diagnosticCodes, diagnostics);
           ^
TSError: ⨯ Unable to compile TypeScript:
invoke.ts(9,3): error TS2724: '"@stellar/stellar-sdk"' has no exported member named 'SorobanRpc'. Did you mean 'Soroban'?

@sreuland
Copy link
Contributor

sreuland commented Jan 8, 2025

@2opremio , RFR - stellar/system-test#114

the bump here to use js sdk 13.1 brought in some changes on names of exported js modules which hadn't been updated in system test's client script usage yet.

once that merges, should rerun ci here, I'm still seeing an error when I buld&run system-test locally with same versions used here, I'm seeing test results with an error related to expected diagnostic events:

Messages:   	Expected 1 diagnostic events for soroban-hello-world-contract using NODEJS but got 2

let's see how e2e CI on this pr runs after stellar/system-test#114 merges

@sreuland
Copy link
Contributor

sreuland commented Jan 9, 2025

@2opremio , RFR - stellar/system-test#115

Additional changes were needed in system-test to handle the latest behaviors from components per the version bumps done here, some things have changed, such as an additional diag event is reported from contract deployment.

same steps needed, once the system-test pr merges, we should re-run ci step here.

@2opremio 2opremio enabled auto-merge (squash) January 9, 2025 18:18
@2opremio 2opremio merged commit 0dbb665 into stellar:main Jan 9, 2025
19 checks passed
@2opremio 2opremio deleted the bump-system-test branch January 9, 2025 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants