soroban-rpc: Pull in Recent Soroban RPC changes from soroban-tools #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Remove panic - 1 * Remove panic - 2 * Remove panic - 3 * Remove panic - 4 * Small changes - 1 * undo changes in Get() func * undo changes - 2 * undo changes - 3 * add test for append error (cherry picked from commit b6671e2)
1. Get rid of the in-memory operation index (since it was always set to zero anyways) 2. Keep events serialized while in memory (it saves quite a bit of space due to the inneficient representation of unions in golang). (cherry picked from commit 433cd44)
(cherry picked from commit 0c77361)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Related to CLI/RPC repo split.
This PR pulls in all merged PRs from
soroban-toolsrepo after this PR.Note: Does not include:
soroban initPR (unrelated to RPC)soroban-toolsso we should do this separately next release fromsoroban-rpc)Why
All new contributions to RPC should live in
soroban-rpc. However, forsoroban-toolswork that was already in progress during the initial repo migration, we should pull RPC related changes into this repo.