Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add prometheus hook to count different log levels #67

Merged
merged 5 commits into from
Feb 16, 2024

Conversation

aditya1702
Copy link
Contributor

What

Part of #22

Adds a hook to the default RPC logger so that it counts the number of error, warning, debug etc... logs generated and shows it on grafana dashboard.

Why

Our current dashboard does not seem to calculate the values.

Known limitations

[TODO or N/A]

@aditya1702 aditya1702 requested a review from tamirms February 16, 2024 20:18
@aditya1702 aditya1702 requested a review from tamirms February 16, 2024 21:24
Copy link
Contributor

@sreuland sreuland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

interesting usage of logs as a source of metrics also, lgtm, but would probably confirm @tamirms approval also as he had prior comments.

@aditya1702 aditya1702 merged commit 448d9ad into stellar:main Feb 16, 2024
20 checks passed
@aditya1702 aditya1702 deleted the add-log-metrics branch February 29, 2024 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants