Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix failures in upload workflow #76

Merged
merged 4 commits into from
Feb 28, 2024
Merged

Fix failures in upload workflow #76

merged 4 commits into from
Feb 28, 2024

Conversation

psheth9
Copy link
Contributor

@psheth9 psheth9 commented Feb 22, 2024

What

When we publish a new release, it fails during upload workflow. This is mainly due to passing opt feature flag in cargo build where there is no declaration of it in toml. This was being used in cli code, so it is safe to remove for now.

Why

We have failures in upload workflow (logs here)
Fixes #81

Known limitations

NA

@psheth9 psheth9 self-assigned this Feb 22, 2024
@psheth9 psheth9 marked this pull request as ready for review February 27, 2024 23:36
@psheth9 psheth9 merged commit 1ed22a2 into main Feb 28, 2024
21 checks passed
@psheth9 psheth9 deleted the fix-upload-job-workflow branch February 28, 2024 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

resolve failures in the upload jobs that happen in publish action
2 participants