Install libdbus-1-dev for cli #109
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this is a dependency for keyring, which we're using for signing with keychains/secure store
34 tasks
willemneal
reviewed
Dec 19, 2024
| @@ -6,6 +6,7 @@ FROM $DOCKERHUB_RUST_VERSION AS builder | |||
| WORKDIR /soroban-tools | |||
| COPY . . | |||
|
|
|||
| run apt update && apt install -y libdbus-1-dev | |||
There was a problem hiding this comment.
Suggested change
| run apt update && apt install -y libdbus-1-dev | |
| run apt update && apt install -y libdbus-1-dev libudev-dev |
Can we add the dep needed for ledger while we are at it?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is a dependency for keyring, which we're using for signing with keychains/secure store
related to stellar/stellar-cli#1481
related cli pr: stellar/stellar-cli#1703