small fixes to Recovery code #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acharb
commented
Oct 30, 2023
| @@ -291,9 +291,7 @@ describe("Path Payment", () => { | |||
| sendAmount: "5", | |||
| }) | |||
| .build(); | |||
| sourceKp.sign(txn); | |||
There was a problem hiding this comment.
unrelated fix. This test fails intermittently when usdc-xlm order book is volatile on testnet, so fixing to just check the operation type (.swap is still submitting to the network and uses .pathPay)
Ifropc
approved these changes
Oct 30, 2023
piyalbasu
added a commit
that referenced
this pull request
Jan 8, 2024
* add type aliases, and make sep24 example use env vars (#66) * add type aliases * make example use env vars * Account setup and recovery using SEP-30 (#65) * Add AccountRecover class * Add Recovery class * Add builderExtra param * Fix importing * Swallow 404 error on registerRecoveryServerSigners function * Remove todo comment * Use plural * Add basic testing * increase timeout * Move private functions to the bottom * Make AccountRecover abstract * Rename type to WalletRecoveryServers * add Customer / SEP-12 code (#71) * add type aliases * make example use env vars * finish tests * add types * cleanup * comment update * use getCustomer * jsdoc * for binary data * clean up * cleanup * use sep9BinaryInfo * cleanup * add gha and linting (#72) * add type aliases * make example use env vars * finish tests * add types * cleanup * add gha * clean up all files * add prettier lint * sep12 stuff linting * cleanup * move to devdeps * add jsdocs to all major functions (#73) * add type aliases * make example use env vars * finish tests * add types * cleanup * add gha * clean up all files * add prettier lint * sep12 stuff linting * cleanup * add for all classes * more comments * more fixes * more changes * cleanup * small fixes to Recovery code (#75) * small fixes * fix path payment test * add sep6 get info (#76) * add SEP6 deposit and withdrawal (#77) * add sep6 deposit and withdrawal * comment * make better response * remove wrapper type * add exchange endpoints (#78) * adding recovery integration tests (#74) * first cut * try workflow * run daemon * print logs * restart on failure * try this * try * try * try * try * cross fingers * fix * works hopefully * fix * add back * cleanup * image versions and readme * add watcher and polling to sep6 (#79) * upgrade stellar-sdk to v11.0.0-beta.6 (#80) * add authToken class (#81) * add authToken class * make account optional * cleanup * remove un-needed account * adding some helper methods (#82) * account merge and premade assets (#83) * add sep38 info, price, and prices (#84) * sep38 getinfo * add prices info, cleanup * move authToken to optional arg * add jsdoc * throw if both buy and sell amount given * add sep38 quote (#85) * sep38 getinfo * add prices info, cleanup * first cut * move authToken to optional arg * cleanup * add jsdoc * throw if both buy and sell amount given * make context type right (#86) * fix test * bumping package version --------- Co-authored-by: Alec Charbonneau <[email protected]> Co-authored-by: Cássio Marcos Goulart <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
some fixes to the recovery code found while running integration tests