Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add npm publish gha #96

Merged
merged 1 commit into from
Jan 30, 2024
Merged

add npm publish gha #96

merged 1 commit into from
Jan 30, 2024

Conversation

acharb
Copy link
Contributor

@acharb acharb commented Jan 30, 2024

ticket

I'll ping ops to add the npm token as a secret

@acharb
Copy link
Contributor Author

acharb commented Jan 30, 2024

@piyalbasu I played around with a way to auto-set the package.json version file using like:
yarn publish --access public -new-version ${{ github.event.release.tag_name }}

but it requires a github profile env var to do looks like

I was also thinking maybe isn't worth the customization? might be annoying with edge cases if we need to like release an older version or something?

@Ifropc
Copy link
Contributor

Ifropc commented Jan 30, 2024

Is this triggered on a new tag?

@acharb
Copy link
Contributor Author

acharb commented Jan 30, 2024

Is this triggered on a new tag?

on a new published release. the js sdk is using the same

@piyalbasu
Copy link
Contributor

@piyalbasu I played around with a way to auto-set the package.json version file using like: yarn publish --access public -new-version ${{ github.event.release.tag_name }}

but it requires a github profile env var to do looks like

I was also thinking maybe isn't worth the customization? might be annoying with edge cases if we need to like release an older version or something?

Ah yeah. I tried to implement something similar in the GHA pipeline for Freighter (https://github.com/stellar/freighter/blob/master/.github/workflows/submitProduction.yml#L65) that updates the version and creates a PR. It's actually really annoying - the CI never runs properly on the generated PR due to a bug in GHA. I was hoping maybe it'd be easier in Jenkins 😄

Probably best to hold off on this for now until I can fix the Freighter version of bumping the version number

@acharb acharb merged commit d2df226 into release/1.4.0 Jan 30, 2024
4 checks passed
@acharb acharb deleted the acharb-npmrelease branch January 30, 2024 22:04
acharb added a commit that referenced this pull request Mar 26, 2024
* fix broken test (#93)

* add sep10 sign challenge txn helper (#95)

* add sep10 helper method

* name change

* correct resp

* create server module

* add npm publish gha (#96)

* WAL-1064 - add anchor platform integration tests (#99)

* create workspace (#101)

* create workspace

* try

* try

* try

* try

* cleanup

* update anchor platform docker run

* fix

* fix

* upgrade babel/traverse

* upgrade browserify-sign

* add keypair package in a second workspace (#102)

* add km package

* fix tests

* cleanup

* add second CD (#109)

* fix stellar-sdk imports (#112)

* fix imports

* fix

* preparing for 1.4.0 release stuff (#110)

* fix

* fix webpack process

* webpack fix (#113)

* webpack fix

* cleanup

* add helper for parsing AnchorTransaction (#111)

* add helper for parsing AnchorTransaction

* use kind

* add try-catch

---------

Co-authored-by: Alec Charbonneau <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants