add KeyManager stuff from old wallet sdk

[acharb]

ticket

largely just lifted from old wallets sdk

[socket-security]

New dependencies detected. Learn more about Socket for GitHub ↗︎

Package	New capabilities	Transitives	Size	Publisher
npm/@albedo-link/[email protected]	None	0	162 kB	orbitlens
npm/@ledgerhq/[email protected]	None	0	188 kB	sergii-shkolin
npm/@ledgerhq/[email protected]	None	+14	5.69 MB	aboissiere, achabrolin-ledger, crema-ledger, ...15 more
npm/@ledgerhq/[email protected]	None	+10	5.68 MB	gre
npm/@ledgerhq/[email protected]	None	0	36.3 kB	sergii-shkolin
npm/@stellar/[email protected]	None	0	56.5 kB	piyalbasu
npm/@trezor/[email protected]	None	+1	365 kB	trezor-ci
npm/[email protected]	None	0	5.99 kB	sir-people
npm/[email protected]	filesystem	+3	131 kB	lmaccherone
npm/[email protected]	None	0	33.6 kB	dchest
npm/[email protected]	Transitive: network	+8	1.44 MB	trezor-ci
npm/[email protected]	None	0	8.14 kB	dchest

View full report↗︎

[socket-security]

🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎

To accept the risk, merge this PR and you will not be notified again.

Alert	Package	Note	Source
Network access	npm/[email protected]	Module: globalThis["fetch"] Location: Package overview	package.json
Network access	npm/[email protected]	Module: http Location: Package overview	package.json
Network access	npm/[email protected]	Module: https Location: Package overview	package.json
Network access	npm/[email protected]	Module: globalThis["fetch"] Location: Package overview	package.json
Filesystem access	npm/[email protected]	Module: fs Location: Package overview	package.json

View full report↗︎

Next steps

What is network access?

This module accesses the network.

Packages should remove all network access that is functionally unnecessary. Consumers should audit network access to ensure legitimate use.

What is filesystem access?

Accesses the file system, and could potentially read sensitive data.

If a package must read the file system, clarify what it will read and ensure it reads only what it claims to. If appropriate, packages can leave file system access to consumers and operate on data passed to it instead.

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/[email protected] or ignore all packages with @SocketSecurity ignore-all

• @SocketSecurity ignore npm/[email protected]
• @SocketSecurity ignore npm/[email protected]
• @SocketSecurity ignore npm/[email protected]

[acharb]

the trezor code is throwing some errors so I'm commenting out for a next PR

@piyalbasu for this error:

Cannot find module 'stellar-sdk' from 'node_modules/@trezor/connect-plugin-stellar/lib/index.js'

    Require stack:
      node_modules/@trezor/connect-plugin-stellar/lib/index.js
      src/walletSdk/KeyManager/handlers/trezor.ts
      src/walletSdk/KeyManager/index.ts
      src/index.ts
      test/keyManager.test.ts

Because trezor has a peer dependency of stellar-sdk , instead of @stellar/stellar-sdk

That's something we need to ask them to change right? or do you know of a way to bypass that?

[CassioMG]

Vibrant is only using KeyType.plaintextKey so we should be fine removing trezor unless Freighter is using it?

[acharb]

cool, I'll leave it commented out for now

looks like freighter is only using plaintextKey too atm

[piyalbasu]

Sorry for the late reply, yeah Freighter is only using plantextKey, so probably okay to drop Trezor support for now

I created this ticket to have Trezor update their deps: https://stellarorg.atlassian.net/browse/WAL-1316

[acharb]

some dev dependencies w/ vulnerabilities looks like, looking into fixing those

[acharb]

hmm looks like there's a dependency alert for cross-fetch and node-fetch, both from the trezor-connect package

maybe another thing to ping trezor about, wdyt @piyalbasu ?

[acharb]

moving to drafts after convo: https://stellarfoundation.slack.com/archives/C03347FNAHK/p1707849301305449

[piyalbasu]

hmm looks like there's a dependency alert for cross-fetch and node-fetch, both from the trezor-connect package

maybe another thing to ping trezor about, wdyt @piyalbasu ?

Yeah, the cross-fetch has a medium supply chain security warning. I'm trying to understand what exactly caused that warning. But something worth flagging with Trezer

The node-fetch warning is less concerning. That warning is more about the fact that node-fetch can load remote code, which is an understood risk and reasonable for the Trezor lib to have to do

[acharb]

closing this PR in lieu of this one that's using yarn workspace