New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[INTERNAL] /transaction/{transactionhash} returns TSSResponse #108

Merged

aristidesstaffieri merged 9 commits into main from feature/get-tx-response-type

Jan 24, 2025

Contributor

aristidesstaffieri commented Jan 23, 2025

Closes #100

What

Makes GetTransaction return a TSSResponse to match the webhook response.

Why

To move towards a unified response type.

Known limitations

N/A

Issue that this PR addresses

PR Structure

It is not possible to break this PR down into smaller PRs.
This PR does not mix refactoring changes with feature changes.
This PR's title starts with name of package that is most changed in the PR, or all if the changes are broad or impact many packages.

Thoroughness

This PR adds tests for the new functionality or fixes.
All updated queries have been tested (refer to this check if the data set returned by the updated query is expected to be same as the original one).

Release

This is not a breaking change.
This is ready to be tested in development.
The new functionality is gated with a feature flag if this is not ready for production.

aristidesstaffieri added 4 commits

January 23, 2025 09:49


          updates GetTransaction to return a TSSResponse

72340bf


          updates GetTransaction test for new response type

c1c8f51


          uses GetTryLatest instead of GetTry to get most recent timestamp for …

db15d23

…hash, updates test


          tweaks readme docker command to match new syntax

9d995b4

aristidesstaffieri requested a review from a team

January 23, 2025 21:32

aristidesstaffieri self-assigned this

gouthamp-stellar reviewed

View reviewed changes

README.md Show resolved Hide resolved

gouthamp-stellar reviewed

View reviewed changes

internal/serve/httphandler/tss_handler.go Outdated Show resolved Hide resolved

JakeUrban reviewed

View reviewed changes

internal/serve/httphandler/tss_handler_test.go Outdated Show resolved Hide resolved

gouthamp-stellar reviewed

View reviewed changes

internal/serve/httphandler/tss_handler_test.go Outdated Show resolved Hide resolved

gouthamp-stellar reviewed

View reviewed changes

internal/serve/httphandler/tss_handler_test.go Outdated Show resolved Hide resolved

gouthamp-stellar reviewed

View reviewed changes

internal/serve/httphandler/tss_handler_test.go Outdated Show resolved Hide resolved

gouthamp-stellar suggested changes

View reviewed changes

Contributor

gouthamp-stellar left a comment

a few small changes to be made and this should be good to go

aristidesstaffieri added 5 commits

January 24, 2025 12:05


          uses correct created at date from Try instead of from tx

71dd031


          removes stray debug log left in test

73a9b82


          renames var to better describe response type

3177c18


          adds a try for the test transaction, asserts on result xdr from try

1c80ae8


          adds unit test for empty result from latest try for transaction

7d2d1c0

Contributor Author

aristidesstaffieri commented Jan 24, 2025

a few small changes to be made and this should be good to go

Thanks for the review. I've added all the requested changes.

aristidesstaffieri requested a review from gouthamp-stellar

January 24, 2025 19:32

gouthamp-stellar approved these changes

View reviewed changes

aristidesstaffieri merged commit a4edb30 into main

5 checks passed

aristidesstaffieri deleted the feature/get-tx-response-type branch

January 24, 2025 21:24

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet