Skip to content

Commit

Permalink
Remove rust-analyzer-compat ci check
Browse files Browse the repository at this point in the history
### What

Remove rust-analyzer-compat ci check.

### Why

We added this when we seemed to be frequently breaking rust-analyzer which slowed down dev envs for devs. But it's been more than 1 year since I've seen anything break rust-analyzer. RA continues to get better, and I don't think we need to keep running this check. There have been at times problems with the check, although not frequent, it's part of our process that isn't serving the need it was created for any longer.
  • Loading branch information
leighmcculloch authored Jul 11, 2024
1 parent 0ed3f3d commit 5dfc73f
Showing 1 changed file with 1 addition and 10 deletions.
11 changes: 1 addition & 10 deletions .github/workflows/rust.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,21 +11,12 @@ jobs:

complete:
if: always()
needs: [rust-analyzer-compat, build-and-test, publish-dry-run]
needs: [build-and-test, publish-dry-run]
runs-on: ubuntu-latest
steps:
- if: contains(needs.*.result, 'failure') || contains(needs.*.result, 'cancelled')
run: exit 1

rust-analyzer-compat:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
- run: rustup update
- run: rustup +nightly component add rust-analyzer
- name: Check if rust-analyzer encounters any errors parsing project
run: rustup run nightly rust-analyzer analysis-stats . 2>&1 | (! grep ERROR)

build-and-test:
strategy:
matrix:
Expand Down

0 comments on commit 5dfc73f

Please sign in to comment.