Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUGFIX]: composer updates to fix Strauss issues causing tests to fail. #440

Merged
merged 18 commits into from
Feb 20, 2024

Conversation

defunctl
Copy link
Contributor

@defunctl defunctl commented Feb 20, 2024

I think I'll still submit a PR after this to convert this to slic since that's what the rest of the company uses, but this:

  1. Fixes broken test framework caused by Strauss prefixing dependencies codeception uses. The fix is to not delete prefixed vendor packages, but this makes development more prone to error because your IDE will show both prefixed and normal package namespaces and if a developer uses a normal namespace, that will cause conflicts when this is installed with other WordPress plugins. This may get fixed in Strauss 1.0..
  2. Replaces all composer installation with the ramsey/composer-install action, which automatically handles caching out of the box.
  3. Re-enables composer validate step and fixes this by adding composer/installers package.
  4. Fixes docker permissions by passing the current user that is running the GitHub action to docker.

@defunctl defunctl added the bug Something isn't working label Feb 20, 2024
@defunctl defunctl self-assigned this Feb 20, 2024
@defunctl defunctl marked this pull request as ready for review February 20, 2024 18:31
@defunctl defunctl merged commit 55c6ec4 into master Feb 20, 2024
4 checks passed
@defunctl defunctl deleted the bugfix/strauss-test-updates branch February 20, 2024 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants