-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(subscription): add support for MQTT notifications #1174
Conversation
3c616be
to
d790223
Compare
Test Results 58 files +1 58 suites +1 1m 24s ⏱️ -1s Results for commit 6765119. ± Comparison against base commit 0f4dbf5. This pull request removes 187 and adds 41 tests. Note that renamed tests count towards both.
♻️ This comment has been updated with latest results. |
d790223
to
d11fcd3
Compare
shared/src/main/kotlin/com/egm/stellio/shared/model/ApiExceptions.kt
Outdated
Show resolved
Hide resolved
subscription-service/src/main/kotlin/com/egm/stellio/subscription/service/mqtt/Mqtt.kt
Show resolved
Hide resolved
...-service/src/test/kotlin/com/egm/stellio/subscription/service/MqttNotificationServiceTest.kt
Outdated
Show resolved
Hide resolved
...ption-service/src/test/kotlin/com/egm/stellio/subscription/service/MqttVersionServiceTest.kt
Outdated
Show resolved
Hide resolved
...ption-service/src/test/kotlin/com/egm/stellio/subscription/service/MqttVersionServiceTest.kt
Outdated
Show resolved
Hide resolved
...ion-service/src/test/kotlin/com/egm/stellio/subscription/service/NotificationServiceTests.kt
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A first quick review
...cription-service/src/main/kotlin/com/egm/stellio/subscription/service/NotificationService.kt
Outdated
Show resolved
Hide resolved
...tion-service/src/main/kotlin/com/egm/stellio/subscription/service/mqtt/MQTTVersionService.kt
Outdated
Show resolved
Hide resolved
...-service/src/test/kotlin/com/egm/stellio/subscription/service/MqttNotificationServiceTest.kt
Outdated
Show resolved
Hide resolved
...ion-service/src/test/kotlin/com/egm/stellio/subscription/service/NotificationServiceTests.kt
Show resolved
Hide resolved
subscription-service/src/test/resources/mosquitto/mosquitto.conf
Outdated
Show resolved
Hide resolved
...-service/src/test/kotlin/com/egm/stellio/subscription/service/MqttNotificationServiceTest.kt
Outdated
Show resolved
Hide resolved
...cription-service/src/main/kotlin/com/egm/stellio/subscription/service/NotificationService.kt
Show resolved
Hide resolved
...service/src/main/kotlin/com/egm/stellio/subscription/service/mqtt/MQTTNotificationService.kt
Outdated
Show resolved
Hide resolved
...tion-service/src/main/kotlin/com/egm/stellio/subscription/service/mqtt/MQTTVersionService.kt
Outdated
Show resolved
Hide resolved
...tion-service/src/main/kotlin/com/egm/stellio/subscription/service/mqtt/MQTTVersionService.kt
Outdated
Show resolved
Hide resolved
Also use the |
141453e
to
49e288d
Compare
...cription-service/src/main/kotlin/com/egm/stellio/subscription/service/NotificationService.kt
Outdated
Show resolved
Hide resolved
...service/src/main/kotlin/com/egm/stellio/subscription/service/mqtt/MqttNotificationService.kt
Outdated
Show resolved
Hide resolved
...service/src/main/kotlin/com/egm/stellio/subscription/service/mqtt/MqttNotificationService.kt
Outdated
Show resolved
Hide resolved
...service/src/main/kotlin/com/egm/stellio/subscription/service/mqtt/MqttNotificationService.kt
Outdated
Show resolved
Hide resolved
...service/src/main/kotlin/com/egm/stellio/subscription/service/mqtt/MqttNotificationService.kt
Outdated
Show resolved
Hide resolved
...ice/src/test/kotlin/com/egm/stellio/subscription/service/mqtt/MqttNotificationServiceTest.kt
Outdated
Show resolved
Hide resolved
...ice/src/test/kotlin/com/egm/stellio/subscription/service/mqtt/MqttNotificationServiceTest.kt
Outdated
Show resolved
Hide resolved
...ice/src/test/kotlin/com/egm/stellio/subscription/service/mqtt/MqttNotificationServiceTest.kt
Show resolved
Hide resolved
2dae40d
to
02f4c45
Compare
there are commits related to this feature that are on the |
...cription-service/src/main/kotlin/com/egm/stellio/subscription/service/NotificationService.kt
Outdated
Show resolved
Hide resolved
...cription-service/src/main/kotlin/com/egm/stellio/subscription/service/NotificationService.kt
Show resolved
Hide resolved
...service/src/main/kotlin/com/egm/stellio/subscription/service/mqtt/MqttNotificationService.kt
Outdated
Show resolved
Hide resolved
025ed9e
to
9195e61
Compare
@thomasBousselin it needs a rebase, the batch merge feature is in the PR |
ae56414
to
ee0f45b
Compare
shared/src/main/kotlin/com/egm/stellio/shared/model/ApiExceptions.kt
Outdated
Show resolved
Hide resolved
shared/src/main/kotlin/com/egm/stellio/shared/model/ApiExceptions.kt
Outdated
Show resolved
Hide resolved
...ption-service/src/test/kotlin/com/egm/stellio/subscription/support/WithMosquittoContainer.kt
Outdated
Show resolved
Hide resolved
...ption-service/src/test/kotlin/com/egm/stellio/subscription/support/WithMosquittoContainer.kt
Outdated
Show resolved
Hide resolved
...service/src/main/kotlin/com/egm/stellio/subscription/service/mqtt/MqttNotificationService.kt
Outdated
Show resolved
Hide resolved
...ice/src/test/kotlin/com/egm/stellio/subscription/service/mqtt/MqttNotificationServiceTest.kt
Outdated
Show resolved
Hide resolved
...ice/src/test/kotlin/com/egm/stellio/subscription/service/mqtt/MqttNotificationServiceTest.kt
Outdated
Show resolved
Hide resolved
...ice/src/test/kotlin/com/egm/stellio/subscription/service/mqtt/MqttNotificationServiceTest.kt
Show resolved
Hide resolved
...ice/src/test/kotlin/com/egm/stellio/subscription/service/mqtt/MqttNotificationServiceTest.kt
Outdated
Show resolved
Hide resolved
191217f
to
d909198
Compare
d53f460
to
6765119
Compare
Quality Gate passedIssues Measures |
Adding Mqtt notification (spec 7.2)