Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: filter with datasetId parameter #1177

Merged
merged 13 commits into from
Jul 19, 2024

Conversation

ranim-n
Copy link
Contributor

@ranim-n ranim-n commented Jun 14, 2024

No description provided.

@ranim-n ranim-n added feature New feature or request ngsild-1.8.1 labels Jun 14, 2024
@ranim-n ranim-n self-assigned this Jun 14, 2024
Copy link
Contributor

github-actions bot commented Jun 14, 2024

Test Results

   57 files  ± 0     57 suites  ±0   1m 21s ⏱️ +3s
  984 tests +14    984 ✅ +14  0 💤 ±0  0 ❌ ±0 
1 023 runs  +14  1 023 ✅ +14  0 💤 ±0  0 ❌ ±0 

Results for commit e0602bc. ± Comparison against base commit 5c63a14.

This pull request removes 202 and adds 62 tests. Note that renamed tests count towards both.
                      "@id": "https://uri…
                      "@type": "@json",
                      …
                    "@value": "/A/B"
                    "@value": "/C/D"
                    "@value": 20
                    "…
                    {
                   …, withTemporalValues=true, withAudit=false, expectation={
                  "@type": "https://uri.etsi.org/ngsi-ld/DateTime",
…
com.egm.stellio.search.service.EntityOperationServiceTests ‑ batch create should ask to create all provided entities()
com.egm.stellio.search.service.EntityOperationServiceTests ‑ batch create should ask to create entities and transmit back any error()
com.egm.stellio.search.service.EntityOperationServiceTests ‑ batch delete should return error messages when deletion in DB has failed()
com.egm.stellio.search.service.EntityOperationServiceTests ‑ batch delete should return the list of deleted entity ids and in errors when deletion is partially successful()
com.egm.stellio.search.service.EntityOperationServiceTests ‑ batch delete should return the list of deleted entity ids when deletion is successful()
com.egm.stellio.search.service.EntityOperationServiceTests ‑ batch merge should ask to merge attributes of entities()
com.egm.stellio.search.service.EntityOperationServiceTests ‑ batch replace should ask to replace entities()
com.egm.stellio.search.service.EntityOperationServiceTests ‑ batch update should ask to update attributes of entities()
com.egm.stellio.search.service.EntityOperationServiceTests ‑ processEntities should count as error a process which raises a BadRequestDataException()
com.egm.stellio.search.service.EntityOperationServiceTests ‑ processEntities should count as error not processed attributes in entities()
…

♻️ This comment has been updated with latest results.

@bobeal bobeal linked an issue Jul 11, 2024 that may be closed by this pull request
2 tasks
@bobeal
Copy link
Member

bobeal commented Jul 11, 2024

datasetId is not handled for temporal queries (it is parsed from the request parameters - or body when in POST query -, as it is shared code with the Core API), but it is not used to filter the results

@bobeal
Copy link
Member

bobeal commented Jul 11, 2024

worth having a look at #1177 (comment)

@bobeal
Copy link
Member

bobeal commented Jul 12, 2024

datasetId is not handled for temporal queries (it is parsed from the request parameters - or body when in POST query -, as it is shared code with the Core API), but it is not used to filter the results

it will start from here: https://github.com/stellio-hub/stellio-context-broker/blob/develop/search-service/src/main/kotlin/com/egm/stellio/search/service/QueryService.kt#L56 and https://github.com/stellio-hub/stellio-context-broker/blob/develop/search-service/src/main/kotlin/com/egm/stellio/search/service/QueryService.kt#L124

Then, of course, SQL requests will have to be enhanced to support datasetId filter.

@bobeal bobeal marked this pull request as ready for review July 15, 2024 11:01
@bobeal
Copy link
Member

bobeal commented Jul 18, 2024

@ranim-n I added some chore and fix commits, I let you have a look.

Copy link

@ranim-n
Copy link
Contributor Author

ranim-n commented Jul 19, 2024

@ranim-n I added some chore and fix commits, I let you have a look.

I can't approve because I am the author of the PR but LGTM

@ranim-n ranim-n force-pushed the feat/filter-on-value-with-specific-datasetId branch from e0602bc to d6331ee Compare July 19, 2024 13:01
@bobeal bobeal merged commit 0f4dbf5 into develop Jul 19, 2024
7 of 8 checks passed
@bobeal bobeal deleted the feat/filter-on-value-with-specific-datasetId branch July 19, 2024 13:46
@github-actions github-actions bot locked and limited conversation to collaborators Jul 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature New feature or request ngsild-1.8.1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Filter on value with specific datasetId
3 participants