Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: interval bounds in temporal queries #1220

Merged
merged 3 commits into from
Aug 15, 2024

Conversation

ranim-n
Copy link
Contributor

@ranim-n ranim-n commented Aug 14, 2024

No description provided.

@ranim-n ranim-n added fix Something isn't working temporal Relates to temporal API labels Aug 14, 2024
@ranim-n ranim-n requested a review from bobeal August 14, 2024 16:27
@ranim-n ranim-n self-assigned this Aug 14, 2024
Copy link
Contributor

github-actions bot commented Aug 14, 2024

Test Results

   60 files  ±0     60 suites  ±0   1m 27s ⏱️ +3s
1 013 tests +4  1 013 ✅ +4  0 💤 ±0  0 ❌ ±0 
1 052 runs  +4  1 052 ✅ +4  0 💤 ±0  0 ❌ ±0 

Results for commit c78be0c. ± Comparison against base commit 7426cb5.

This pull request removes 187 and adds 37 tests. Note that renamed tests count towards both.
                      "@id": "https://uri…
                      "@type": "@json",
                      …
                    "@value": "/A/B"
                    "@value": "/C/D"
                    "@value": 20
                    "…
                    {
                   …, withTemporalValues=true, withAudit=false, expectation={
                  "@type": "https://uri.etsi.org/ngsi-ld/DateTime",
…
com.egm.stellio.search.scope.ScopeServiceTests ‑ it should exclude upper bound of interval with between timerel()
com.egm.stellio.search.scope.ScopeServiceTests ‑ it should include lower bound of interval with after timerel()
com.egm.stellio.search.service.AttributeInstanceServiceTests ‑ it should exclude upper bound of interval with between timerel()
com.egm.stellio.search.service.AttributeInstanceServiceTests ‑ it should include lower bound of interval with after timerel()
com.egm.stellio.search.util.PatchAttributeTests ‑ [1] source={
    "attribute": {
        "type": "Property",
        "value": 12.0,
        "observedAt": "2024-04-14T12:34:56Z"
    }
}, target={
    "attribute": {
        "type": "Property",
        "value": 12.2,
        "unitCode": "GRM"
    }
}, expected={
    "attribute": {
        "type": "Property",
        "value": 12.2,
        "unitCode": "GRM",
        "observedAt": "2024-04-14T12:34:56Z"
    }
}
com.egm.stellio.search.util.PatchAttributeTests ‑ [1] source={
    "attribute": {
        "type": "Property",
        "value": 12.0,
        "observedAt": "2024-04-14T12:34:56Z",
        "subAttribute": {
            "type": "Property",
            "value": "subAttribute"
        }
    }
}, target={
    "attribute": {
        "type": "Property",
        "value": 12.2,
        "unitCode": "GRM",
        "subAttribute": {
            "type": "Property",
            "value": "newSubAttributeValue"
        }
    }
}, expected={
    "attribute": {
        "type": "Property",
        "value": 12.2,
        "unitCode": "GRM",
        "observedAt": "2024-04-14T12:34:56Z",
        "subAttribute": {
            "type": "Property",
            "value": "newSubAttributeValue"
        }
    }
}
com.egm.stellio.search.util.PatchAttributeTests ‑ [2] source={
    "attribute": {
        "type": "Property",
        "value": { "en": "car", "fr": "voiture" }
    }
}, target={
    "attribute": {
        "type": "Property",
        "value": { "fr": "vélo", "es": "bicicleta" }
    }
}, expected={
    "attribute": {
        "type": "Property",
        "value": { "en": "car", "fr": "vélo", "es": "bicicleta" }
    }
}
com.egm.stellio.search.util.PatchAttributeTests ‑ [2] source={
    "incoming": {
        "type": "JsonProperty",
        "json": { "id": 1, "b": null, "c": 12.4 },
        "observedAt": "2022-12-24T14:01:22.066Z",
        "subAttribute": {
            "type": "Property",
            "value": "subAttribute"
        }
    }
}, target={
    "incoming": {
        "type": "JsonProperty",
        "json": { "id": 2, "b": "something" },
        "observedAt": "2023-12-24T14:01:22.066Z"
    }
}, expected={
    "incoming": {
        "type": "JsonProperty",
        "json": { "id": 2, "b": "something" },
        "observedAt": "2023-12-24T14:01:22.066Z",
        "subAttribute": {
            "type": "Property",
            "value": "subAttribute"
        }
    }
}
com.egm.stellio.search.util.PatchAttributeTests ‑ [3] source={
    "attribute": {
        "type": "Property",
        "value": [ "car", "voiture" ]
    }
}, target={
    "attribute": {
        "type": "Property",
        "value": [ "vélo", "bicicleta" ]
    }
}, expected={
    "attribute": {
        "type": "Property",
        "value": [ "vélo", "bicicleta" ]
    }
}
com.egm.stellio.search.util.PatchAttributeTests ‑ [3] source={
    "attribute": {
        "type": "VocabProperty",
        "vocab": "stellio"
    }
}, target={
    "attribute": {
        "type": "VocabProperty",
        "vocab": "egm"
    }
}, expected={
    "attribute": {
        "type": "VocabProperty",
        "vocab": "egm"
    }
}
…

♻️ This comment has been updated with latest results.

Copy link

@bobeal bobeal merged commit a740e14 into develop Aug 15, 2024
10 checks passed
@bobeal bobeal deleted the fix/interval-bounds-in-temporal-query branch August 15, 2024 07:10
@github-actions github-actions bot locked and limited conversation to collaborators Aug 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
fix Something isn't working temporal Relates to temporal API
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants