-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(common): simplify internal error handling #1264
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results 67 files ±0 67 suites ±0 1m 21s ⏱️ ±0s Results for commit 43702bc. ± Comparison against base commit bd5146d. This pull request removes 189 and adds 33 tests. Note that renamed tests count towards both.
♻️ This comment has been updated with latest results. |
thomasBousselin
force-pushed
the
feature/simplify-error-handling
branch
from
November 15, 2024 17:15
22d88ec
to
9da8284
Compare
bobeal
reviewed
Nov 16, 2024
shared/src/main/kotlin/com/egm/stellio/shared/model/ApiExceptions.kt
Outdated
Show resolved
Hide resolved
bobeal
reviewed
Nov 16, 2024
shared/src/main/kotlin/com/egm/stellio/shared/model/ApiExceptions.kt
Outdated
Show resolved
Hide resolved
bobeal
reviewed
Nov 16, 2024
thomasBousselin
force-pushed
the
feature/simplify-error-handling
branch
2 times, most recently
from
November 18, 2024 13:50
384b5c1
to
16509a4
Compare
thomasBousselin
force-pushed
the
feature/simplify-error-handling
branch
from
November 18, 2024 16:20
a42108c
to
33c90bb
Compare
bobeal
reviewed
Nov 19, 2024
shared/src/main/kotlin/com/egm/stellio/shared/model/ApiExceptions.kt
Outdated
Show resolved
Hide resolved
shared/src/main/kotlin/com/egm/stellio/shared/model/ApiExceptions.kt
Outdated
Show resolved
Hide resolved
shared/src/main/kotlin/com/egm/stellio/shared/model/ApiExceptions.kt
Outdated
Show resolved
Hide resolved
bobeal
approved these changes
Nov 21, 2024
bobeal
changed the title
Feature/simplify error handling
feat(common): simplify internal error handling
Nov 21, 2024
ranim-n
approved these changes
Nov 22, 2024
Detail is now used to redirect people to troubleshoot.
thomasBousselin
force-pushed
the
feature/simplify-error-handling
branch
from
November 22, 2024 16:16
6fa2109
to
43702bc
Compare
Quality Gate passedIssues Measures |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.