-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(common): return an InvalidRequest
error when a parameter is invalid - 6.3.20
#1271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results 18 files - 43 18 suites - 43 6s ⏱️ -51s Results for commit 8b27814. ± Comparison against base commit ed38961. This pull request removes 887 and adds 4 tests. Note that renamed tests count towards both.
|
thomasBousselin
force-pushed
the
feature/request-param-refacto
branch
2 times, most recently
from
November 28, 2024 11:01
7e1fb8e
to
9803a58
Compare
bobeal
reviewed
Nov 28, 2024
search-service/src/main/kotlin/com/egm/stellio/search/entity/service/EntityQueryService.kt
Outdated
Show resolved
Hide resolved
shared/src/main/kotlin/com/egm/stellio/shared/model/parameter/GeoQuery.kt
Outdated
Show resolved
Hide resolved
search-service/src/main/kotlin/com/egm/stellio/search/entity/web/EntityHandler.kt
Outdated
Show resolved
Hide resolved
search-service/src/main/kotlin/com/egm/stellio/search/temporal/util/TemporalQueryParamsUtils.kt
Show resolved
Hide resolved
shared/src/main/kotlin/com/egm/stellio/shared/web/ExceptionHandler.kt
Outdated
Show resolved
Hide resolved
shared/src/main/kotlin/com/egm/stellio/shared/web/ExceptionHandler.kt
Outdated
Show resolved
Hide resolved
...tion-service/src/main/kotlin/com/egm/stellio/subscription/job/TimeIntervalNotificationJob.kt
Outdated
Show resolved
Hide resolved
shared/src/main/kotlin/com/egm/stellio/shared/model/parameter/QueryParameter.kt
Outdated
Show resolved
Hide resolved
thomasBousselin
force-pushed
the
feature/request-param-refacto
branch
from
November 29, 2024 15:53
5c9fe84
to
a5abbf0
Compare
bobeal
changed the title
Feature/request param validation
feat(common): return an Nov 30, 2024
InvalidRequest
error when a parameter is invalid - 6.3.20
bobeal
reviewed
Nov 30, 2024
search-service/src/main/kotlin/com/egm/stellio/search/entity/web/EntityHandler.kt
Outdated
Show resolved
Hide resolved
search-service/src/main/kotlin/com/egm/stellio/search/entity/web/EntityOperationHandler.kt
Outdated
Show resolved
Hide resolved
...h-service/src/main/kotlin/com/egm/stellio/search/csr/web/ContextSourceRegistrationHandler.kt
Outdated
Show resolved
Hide resolved
...rvice/src/main/kotlin/com/egm/stellio/search/temporal/web/TemporalEntityOperationsHandler.kt
Outdated
Show resolved
Hide resolved
shared/src/main/kotlin/com/egm/stellio/shared/queryparameter/AllowedParameters.kt
Outdated
Show resolved
Hide resolved
shared/src/main/kotlin/com/egm/stellio/shared/queryparameter/OptionsValue.kt
Outdated
Show resolved
Hide resolved
|
bobeal
reviewed
Dec 3, 2024
...rvice/src/main/kotlin/com/egm/stellio/search/authorization/web/EntityAccessControlHandler.kt
Outdated
Show resolved
Hide resolved
search-service/src/main/kotlin/com/egm/stellio/search/temporal/web/TemporalApiResponses.kt
Show resolved
Hide resolved
search-service/src/test/kotlin/com/egm/stellio/search/entity/web/EntityHandlerTests.kt
Outdated
Show resolved
Hide resolved
search-service/src/test/kotlin/com/egm/stellio/search/entity/web/EntityHandlerTests.kt
Outdated
Show resolved
Hide resolved
shared/src/main/kotlin/com/egm/stellio/shared/queryparameter/AllowedParameters.kt
Outdated
Show resolved
Hide resolved
shared/src/main/kotlin/com/egm/stellio/shared/queryparameter/AllowedParameters.kt
Outdated
Show resolved
Hide resolved
Co-authored-by: Benoit Orihuela <[email protected]>
thomasBousselin
force-pushed
the
feature/request-param-refacto
branch
from
December 5, 2024 13:19
dd8f655
to
d35ef76
Compare
ranim-n
reviewed
Dec 5, 2024
...h-service/src/main/kotlin/com/egm/stellio/search/csr/web/ContextSourceRegistrationHandler.kt
Outdated
Show resolved
Hide resolved
ranim-n
approved these changes
Dec 5, 2024
…ContextSourceRegistrationHandler.kt Co-authored-by: Ranim Naimi <[email protected]>
bobeal
reviewed
Dec 5, 2024
...rvice/src/main/kotlin/com/egm/stellio/search/authorization/web/EntityAccessControlHandler.kt
Show resolved
Hide resolved
bobeal
approved these changes
Dec 5, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Still need to add the annotation to all the endpoints.