Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(common): return an InvalidRequest error when a parameter is invalid - 6.3.20 #1271

Merged
merged 24 commits into from
Dec 6, 2024

Conversation

thomasBousselin
Copy link
Contributor

Still need to add the annotation to all the endpoints.

@github-actions github-actions bot added the feature New feature or request label Nov 27, 2024
Copy link
Contributor

Test Results

 18 files   -  43   18 suites   - 43   6s ⏱️ -51s
209 tests  - 727  209 ✅  - 726  0 💤 ±0  0 ❌  - 1 
209 runs   - 766  209 ✅  - 765  0 💤 ±0  0 ❌  - 1 

Results for commit 8b27814. ± Comparison against base commit ed38961.

This pull request removes 887 and adds 4 tests. Note that renamed tests count towards both.
                                    { "id":…, withTemporalValues=true, withAudit=false, expectation={
                      "@id": "https://uri…
                      "@type": "@json",
                      …
                    "@value": "/A/B"
                    "@value": "/C/D"
                    "@value": 20
                    "…
                    {
                  "@type": "https://uri.etsi.org/ngsi-ld/DateTime",
…
com.egm.stellio.shared.model.LanguageFilterTests ‑ [1] nl, "languageProperty": {
    "type": "Property",
    "value": "Grote Markt",
    "lang": "nl"
}
com.egm.stellio.shared.model.LanguageFilterTests ‑ [2] en, "languageProperty": {
    "type": "Property",
    "value": "Big Place",
    "lang": "@none"
}
com.egm.stellio.shared.model.LanguageFilterTests ‑ [3] *, "languageProperty": {
    "type": "Property",
    "value": "Big Place",
    "lang": "@none"
}
com.egm.stellio.shared.model.LanguageFilterTests ‑ [4] fr-CH,fr;q=0.9,en;q=0.8,*;q=0.5, "languageProperty": {
    "type": "Property",
    "value": "Grand Place",
    "lang": "fr"
}

@github-actions github-actions bot locked and limited conversation to collaborators Nov 27, 2024
@thomasBousselin thomasBousselin force-pushed the feature/request-param-refacto branch 2 times, most recently from 7e1fb8e to 9803a58 Compare November 28, 2024 11:01
@thomasBousselin thomasBousselin force-pushed the feature/request-param-refacto branch from 5c9fe84 to a5abbf0 Compare November 29, 2024 15:53
@bobeal bobeal marked this pull request as ready for review November 30, 2024 09:07
@bobeal bobeal added the common Relates to common behaviors label Nov 30, 2024
@bobeal bobeal linked an issue Nov 30, 2024 that may be closed by this pull request
@bobeal bobeal changed the title Feature/request param validation feat(common): return an InvalidRequest error when a parameter is invalid - 6.3.20 Nov 30, 2024
@bobeal
Copy link
Member

bobeal commented Nov 30, 2024

  • pushed somes fixes and renamings
  • it is missing tests (here and in the conformance test suite)

@thomasBousselin thomasBousselin force-pushed the feature/request-param-refacto branch from dd8f655 to d35ef76 Compare December 5, 2024 13:19
…ContextSourceRegistrationHandler.kt

Co-authored-by: Ranim Naimi <[email protected]>
@thomasBousselin thomasBousselin merged commit 5468f6d into develop Dec 6, 2024
11 checks passed
@thomasBousselin thomasBousselin deleted the feature/request-param-refacto branch December 6, 2024 14:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
common Relates to common behaviors feature New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Return an InvalidRequest error when a parameter is invalid - 6.3.20
3 participants