Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pre-setting FileObject._is_folder for performance #131

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

wonderbeyond
Copy link

This is especially useful for filebrowser_safe.views.browse,
in which we already know whether an object is folder or not
before initializing the FileObject instance.

PS: I am using S3 storage backend, I can observe about 3x performance optimization.

RandomJo and others added 8 commits January 30, 2019 15:58
The listdir function returns two values, one for directory names and one
for file names. These are lists of strings and thus do not have a delete
method. Instead of trying to delete each array, we loop through them to
build keys that we can delete.
…or_gcs

Fixes issues with old methods in GoogleStorageMixin
Fix rmtree method of S3BotoStorageMixin
…ication

Fix cs specification that is breaking compilemessages command
Fix issues with old methods in GoogleStorageMixin
This is especially useful for `filebrowser_safe.views.browse`,
in which we already know whether an object is folder or not
before initializing the FileObject instance.

PS: I am using S3 storage backend, I can observe about 3x performance optimization.
@jerivas jerivas force-pushed the master branch 2 times, most recently from e04a9c1 to c7eceb0 Compare August 12, 2020 01:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants