Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Filters for type of vaccine, age, minimum fare etc #144

Open
stephin007 opened this issue Jun 3, 2021 · 7 comments
Open

Add Filters for type of vaccine, age, minimum fare etc #144

stephin007 opened this issue Jun 3, 2021 · 7 comments
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed new feature

Comments

@stephin007
Copy link
Owner

stephin007 commented Jun 3, 2021

Is your feature request related to a problem? Please describe.
RIght now, when data is displayed, there is no option to filter on the basis of
- Type of Vaccine
- Age
- Minimum fare and more.
Adding this filter will help user to drill down their searches.

Describe the solution you'd like
A simple filter which uses filter functionality on the basis of the data coming from the API, this filter must either be dynamic enough to handle all the filter queries at once or create a filter which can give the user option to select only one filter at a time.

In other words: you should create a dropdown which has the filter labels as follows:

  • Vaccine Type
  • Age Group
  • Fare Type

And according to each option you can show other relevant options , say for example if i select vaccine type , i should see another drop just beside the above dropdown which has dropdown option of covishield and covaxin.

So in the UI, User will only see 2 dropdowns!

💡 Additional required information 💡

Make sure you make a general filter so that we can add more filter parameters to the list if we want!
Let me know if you still have any doubts regarding the requirement.

@stephin007 stephin007 added enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed new feature labels Jun 3, 2021
@eddierayo-156
Copy link

May I try to tackle this issue as my first contribution to open source projects?

@stephin007
Copy link
Owner Author

Sure @eddierayo-156 , but few questions:

  • what will be your approach to achieve this?
  • Will you be adding any new package?
  • Will there be any changes which needs to be added in the documentation/Readme of this project?

@himanshujasuja1040
Copy link
Contributor

I would like to take this issue .
Answer for above questions :
1.My approach is by initialy checking Vaccine availability , if it is available then I will create a filter box from where the vaccine get easily Filter.
2. Nope
3. Nope

@stephin007
Copy link
Owner Author

Great @himanshujasuja1040 assigning you! Please send a screenshot of the UI you create for the filter.

@eddierayo-156 you can also try , assigning you as well but first please asnwer the questions i asked!

Thanks ❤️

@suryansh38
Copy link

1.using any of the api's i will get fetch the data and implement a function to filter the data in the state according to the (min-age) label.
2.no
3.no

@stephin007
Copy link
Owner Author

@suryansh38 , not only min age add fare, vaccine name, etc .Make a general one, so that if we want we can add more filter parameters.

Assigning you the issue as well.

@stephin007
Copy link
Owner Author

@eddierayo-156 @himanshujasuja1040 @suryansh38 Guys, Make sure you make a general filter so that we can add more filter parameters to the list if we want!
Let me know if you still have any doubts regarding the requirement.

@stephin007 stephin007 linked a pull request Jun 7, 2021 that will close this issue
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed new feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants