Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FilterIssue #150

Conversation

himanshujasuja1040
Copy link
Contributor

@himanshujasuja1040 himanshujasuja1040 commented Jun 7, 2021

🚨 Please review the guidelines for contributing to this repository.

Please check if the PR fulfills these requirements

  • Make sure you are requesting to NEW-UI. Don't request other protected Branches like staging/master :yes
  • Make sure no conflicts are present in the code, if so please resolve it(Tip: Always fetch upstream) : No conflict
  • Your Commit messages should make sense. : Yup
  • Don't push your package.lock.json as this project uses yarn.lock already. :ok
  • Check your code additions will fail neither code linting checks nor unit test. :ok

Describe your changes

  • What kind of change does this PR introduce? : (Filter Bug Fixed)

  • What is the current behavior? : (Not Have any Filter component)

  • What is the new behavior (if this is a feature change)? : (Added a Filter Component for filtering vaccine)

  • Does this PR introduce a breaking change? :(Nope)

  • Other Information: (Nope)

❤️ Thank you!

@vercel
Copy link

vercel bot commented Jun 7, 2021

Someone is attempting to deploy a commit to a Personal Account owned by @stephin007 on Vercel.

@stephin007 first needs to authorize it.

@himanshujasuja1040
Copy link
Contributor Author

@Justinnn07

@stephin007
Copy link
Owner

Complete the PR template @himanshujasuja1040

@vercel
Copy link

vercel bot commented Jun 7, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/stephin007/cowin-vaccine-availablity-checker/eQZNGgydSNmDyDgDHAHyFpbLRtgV
✅ Preview: https://cowin-vaccine-git-fork-himanshujasuja1040-himanshujasuj-d018b3.vercel.app

@stephin007
Copy link
Owner

@himanshujasuja1040 Add no data found component, when no data is found according to the added filters.

@Justinnn07
Copy link
Collaborator

@himanshujasuja1040 great work!
Few points to be noted:-

  1. Please remove the pagination ..
  2. If the filtered array is 0, please show the no data found component ..
  3. The Fare filter is not working ..

Thanks

@Justinnn07
Copy link
Collaborator

@himanshujasuja1040 any update?

@stephin007
Copy link
Owner

Outdated PR, closing it!

@stephin007 stephin007 closed this Jun 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Filters for type of vaccine, age, minimum fare etc
3 participants